Skip to content

[13.0][UPT]fetchmail_notify_error_to_sender remove dependency on test_mail #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 1 commit into from
Jul 9, 2020
Merged

[13.0][UPT]fetchmail_notify_error_to_sender remove dependency on test_mail #1857

OCA-git-bot merged 1 commit into from
Jul 9, 2020

Conversation

@AaronHForgeFlow
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow commented Jul 3, 2020 •
edited
Loading

Why this? Because of that:
#1485 (comment)

@AaronHForgeFlow AaronHForgeFlow force-pushed the 13.0-upt-fetchmail_notify_error_to_sender branch from ff22129 to 2183156 Compare July 3, 2020 12:14
@AaronHForgeFlow AaronHForgeFlow force-pushed the 13.0-upt-fetchmail_notify_error_to_sender branch from 2183156 to c573841 Compare July 3, 2020 12:26
@AaronHForgeFlow
Copy link
Contributor Author

AaronHForgeFlow commented Jul 3, 2020

@LoisRForgeFlow

LoisRForgeFlow
LoisRForgeFlow approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! we are making production environments a little bit less heavy :)

@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Jul 3, 2020

@yajo can you have a look?

etobella
etobella approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great to remove this dependency

jarroyomorales
jarroyomorales approved these changes Jul 9, 2020
View reviewed changes
Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 9, 2020

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@LoisRForgeFlow
Copy link
Contributor

LoisRForgeFlow commented Jul 9, 2020

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 9, 2020

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1857-by-LoisRForgeFlow-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6c05fb5 into OCA:13.0 Jul 9, 2020
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Jul 9, 2020

Congratulations, your PR was merged at 37f356e. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 13.0-upt-fetchmail_notify_error_to_sender branch July 9, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@etobella etobella etobella approved these changes

+2 more reviewers

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

@jarroyomorales jarroyomorales jarroyomorales approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AaronHForgeFlow @LoisRForgeFlow @OCA-git-bot @etobella @AdriaGForgeFlow @jarroyomorales