[12.0][FIX]database_cleanup: Don't purge by default

[diggy128]

Modules should not be purged when completing scan without
explicit user consent. Instead select modules to purge from results.

After applied fixed an issue similar to #1534

[thomaspaulb]

/ocabot merge minor

[StefanRijnhart]

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1978-by-StefanRijnhart-bump-minor, awaiting test results.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1978-by-StefanRijnhart-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[thomaspaulb]

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-1978-by-thomaspaulb-bump-minor, awaiting test results.

[OCA-git-bot]

@thomaspaulb your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-1978-by-thomaspaulb-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[thomaspaulb]

@diggy128 Interestingly, after your fix this test now fails, because it actually tests for a module already being purged during default_get.

@hbrunn Blame for that test leads to you; do you have any idea why it's there?

[StefanRijnhart]

Yep, looks like purging modules immediately was a conscious change according to the explanation in this PR: #1316

[hbrunn]

thanks @StefanRijnhart, that's it. But by now we have the purge all button, and starting in version 14 they threw out this behavior anyways during migration.

[thomaspaulb]

So I modified tests as per discussion above, in #2857

Closing this.