Skip to content

Conversation

@etobella
Copy link
Member

Standard migration.

No major changes

Taken #1616 as base

sebalix and others added 18 commits June 21, 2021 12:05
…figuration file path added on the NSCA server (each server can require a different password)
…end' removed, replaced by a check at the runtime
…essage will be sent to the NSCA server instead of a CRITICAL one
…end_nsca' binary, password and encryption method are set in 'nsca.server' records
…tion file path in order to be compatible with a multi-databases instance
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@etobella etobella force-pushed the 13.0-mig-nsca_client branch from 12a6086 to df4d376 Compare June 21, 2021 11:34
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

Copy link
Contributor

@olgamarcocb olgamarcocb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@albariera albariera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@thomaspaulb
Copy link

/ocabot migration nsca_client
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 13.0 milestone Sep 1, 2022
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-2111-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7b4eb63 into OCA:13.0 Sep 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7e2d846. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants