[MIG][12.0] letsencrypt #2395
Merged
[MIG][12.0] letsencrypt #2395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] letsencrypt (OCA#347) * [ADD] letsencrypt * [ADD] write bogus restart script for tests * [IMP] exclude library call from coveralls * [IMP] try moving the library import into nocover branch * [ADD] explain how to redirect the well known uri to the odoo instance * [ADD] example for apache * [FIX] cronjob should be noupdate * [FIX] community review * [FIX] flake8 * [DEL] unused imports * [UPD] chain cert * Multi-database support and other fixes (#2) [ADD] multi-database support and other fixes * [ADD] eggs necessary for letsencrypt * [IMP] readme * [ADD] ipv6 localhosts * [ADD] restrict reload command * Revert "[ADD] eggs necessary for letsencrypt" This reverts commit 642df6b. * [ADD] eggs necessary for letsencrypt Conflicts: requirements.txt * Migrate letsencrypt to v9 * Add AGPL target link to ReadMe in letsencrypt
…CA#757) * [FIX] Make letsencrypt resilient for alternate name removal. * [FIX] Do not crash when returning error in letsencrypt cmdline. * [FIX] Restore ordering by name for alternate domains in letsencrypt. Conflicts: letsencrypt/README.rst
Currently translated at 100,0% (7 of 7 strings) Translation: server-tools-11.0/server-tools-11.0-letsencrypt Translate-URL: https://translation.odoo-community.org/projects/server-tools-11-0/server-tools-11-0-letsencrypt/pt_BR/
The domain-based filename is fragile. Just reordering domains in the settings can change it. If migrating from an old version symlinks are used to avoid breaking anything.
Author
|
@dreispt @NL66278 Could you review this again? I changed the last commit as compared to #1883, explanation of the method in #2014 (comment) |
NL66278
reviewed
Sep 5, 2022
| @@ -0,0 +1,5 @@ | |||
| # © 2016 Therp BV <http://therp.nl> | |||
Contributor
There was a problem hiding this comment.
Delete copyright lines from init.py files
NL66278
reviewed
Sep 5, 2022
| @@ -0,0 +1,5 @@ | |||
| # © 2016 Therp BV <http://therp.nl> | |||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | |||
Contributor
There was a problem hiding this comment.
And these kind of lines should be https:
NL66278
reviewed
Sep 5, 2022
| # © 2016 Therp BV <http://therp.nl> | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
| { | ||
| "name": "Let's Encrypt", |
NL66278
approved these changes
Sep 5, 2022
Contributor
NL66278
left a comment
NL66278
left a comment
There was a problem hiding this comment.
👍 LGTM And known to work well. Some nags, but not blocking.
Author
|
Seeing as other people already confirmed the previous PR, merging this. |
Author
|
/ocabot migration letsencrypt |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
Contributor
|
Congratulations, your PR was merged at 9974e2f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry of #1883
(it needs fixing, but
janverbis no longer working with us and so we cannot push to the branch)