Skip to content

Conversation

@valentincastravete
Copy link

@valentincastravete valentincastravete commented Mar 5, 2024

Retake of #2791

@valentincastravete
Copy link
Author

Hi @thomaspaulb

I've fixed all the tests and recreate the MR as the other one was a bit "dirty", sorry about that.
The branch also has been recently rebased, so it's all ready to Merge.

Thanks!

@thomaspaulb
Copy link

@valentincastravete Thanks! I would merge, there's just one minor thing, is that the pre-commit changes and the actual changes are in the same commit. It's easier to review and also to look back if these are separated in two commits.

It's pretty easy to do, something like

cp -R auto_backup /tmp/auto_backup
git reset --hard HEAD~1
pre-commit run -A
git commit -a -m "[UPD] black, isort, prettier"
rm -Rf auto_backup
cp -R /tmp/auto_backup .
git add .
git commit -m "[MIG] auto_backup to 12.0"

Copy link

@JorgeQuinteros JorgeQuinteros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@valentincastravete
Copy link
Author

@thomaspaulb
Two separated commits done! Thanks for the tip/minor thing advice.
All ready now?

@valentincastravete valentincastravete changed the title [MIG] auto_backup: Migration to 12.0 [12.0][MIG] auto_backup: Migration to 12.0 Mar 6, 2024
@valentincastravete valentincastravete changed the title [12.0][MIG] auto_backup: Migration to 12.0 [MIG] auto_backup: Migration to 12.0 Mar 6, 2024
@valentincastravete valentincastravete changed the title [MIG] auto_backup: Migration to 12.0 [12.0][MIG] auto_backup: Migration to 12.0 Mar 6, 2024
@thomaspaulb
Copy link

@valentincastravete All good now and thanks a lot!

/ocabot merge nobump

/ocabot migration auto_backup

@OCA-git-bot OCA-git-bot added this to the 12.0 milestone Mar 6, 2024
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-2872-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 6, 2024
32 tasks
@OCA-git-bot OCA-git-bot merged commit cd9ceb2 into OCA:12.0 Mar 6, 2024
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3e9d569. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants