-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[12.0][MIG] auto_backup: Migration to 12.0 #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @thomaspaulb I've fixed all the tests and recreate the MR as the other one was a bit "dirty", sorry about that. Thanks! |
|
@valentincastravete Thanks! I would merge, there's just one minor thing, is that the pre-commit changes and the actual changes are in the same commit. It's easier to review and also to look back if these are separated in two commits. It's pretty easy to do, something like |
JorgeQuinteros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@thomaspaulb |
|
@valentincastravete All good now and thanks a lot! /ocabot merge nobump /ocabot migration auto_backup |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 3e9d569. Thanks a lot for contributing to OCA. ❤️ |
Retake of #2791