Skip to content

[17.0][MIG] tracking_manager #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 21 commits into from
May 2, 2024
Merged

[17.0][MIG] tracking_manager #2916

OCA-git-bot merged 21 commits into from
May 2, 2024

Conversation

@CRogos
Copy link
Contributor

@CRogos CRogos commented Apr 22, 2024

No description provided.

@CRogos CRogos mentioned this pull request Apr 22, 2024
Open
38 tasks
@CRogos CRogos force-pushed the 17.0-mig-tracking_manager branch from 6c077b4 to cbfc38e Compare April 22, 2024 10:00
@CRogos CRogos marked this pull request as draft April 22, 2024 10:10
@CRogos CRogos force-pushed the 17.0-mig-tracking_manager branch 8 times, most recently from 0719033 to 3928339 Compare April 24, 2024 12:32
@CRogos CRogos marked this pull request as ready for review April 24, 2024 12:35
GuillemCForgeFlow
GuillemCForgeFlow reviewed Apr 25, 2024
View reviewed changes
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions, for the rest I have functionally tested and works fine 👍🏿

@CRogos CRogos force-pushed the 17.0-mig-tracking_manager branch from 3928339 to 358c4fe Compare April 25, 2024 20:34
GuillemCForgeFlow
GuillemCForgeFlow approved these changes Apr 26, 2024
View reviewed changes
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! functional and code review 👍🏿
thank you for accepting the suggestions btw 😄
you can already mark all discussions as resolved!

MohamedOsman7
MohamedOsman7 approved these changes Apr 29, 2024
View reviewed changes
Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code & functional review LGTM

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Apr 29, 2024

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link
Contributor Author

CRogos commented May 2, 2024

@pedrobaeza could you merge this?

@pedrobaeza
Copy link
Member

pedrobaeza commented May 2, 2024

/ocabot merge nobump
/ocabot migration tracking_manager

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 2, 2024
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 2, 2024

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-2916-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 2, 2024
@OCA-git-bot
Merge PR #2916 into 17.0
8fbe54c 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 2, 2024

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-2916-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

pedrobaeza commented May 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 2, 2024

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2916-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 2, 2024
@OCA-git-bot
Merge PR #2916 into 17.0
6e6361d 
Signed-off-by pedrobaeza
sebastienbeau and others added 20 commits May 2, 2024 12:47
@sebastienbeau @CRogos
tracking_manager: remove useless file
5631263
@sebastienbeau @CRogos
tracking_manager: refactor code, remove tracking_model
be22968 
- remove tracking_model (less model, less code, less issue)
- add automatic rule for default config (this avoid missing tracked field
after module installation)
@sebastienbeau @CRogos
tracking_manager: refactor code to track all o2m case
e907729 
For example on the product if you open the 'stock.putaway.rule'
you have activated the tracking on putaway_rule_ids
change on rule should be posted on the related product
@sebastienbeau @CRogos
tracking_manager: refactor test
572cab4
@sebastienbeau @CRogos
tracking_manager: continue to refactor code
be72996 
- track m2m simplify using native mail_thread and process them like text
- simplify code for track one2many
- avoid useless code on model not impacted by the tracking
@sebastienbeau @CRogos
tracking_manager: simplify code by using precommit feature
6500e27 
Instead of complexe tracking throught the context
just track change and process the message at the end
using the precommit feature (the message are posted
just before commiting)
@Kev-Roche @CRogos
IMP readme and add filters
7dda71b
@Kev-Roche @yostashiro @CRogos
Update tracking_manager/readme/USAGE.rst
12c28ad 
Co-authored-by: Yoshi Tashiro (Quartile) <tashiro@quartile.co>
@sebastienbeau @CRogos
tracking_manager: use sudo for posting message
c688772
@sebastienbeau @CRogos
tracking_manager: fix missing error when doing a write before an unlink
4a8d86f
@Kev-Roche @CRogos
minor fixes
c5a518e
@sebastienbeau @CRogos
tracking_manager: fix access right issue if sudo have been used
ac23d1b
@CRogos
[MIG] tracking_manager: Migration to 15.0
4021760
@CRogos
[MIG] tracking_manager: Migration to 16.0
48fa079
@mymage @CRogos
Added translation using Weblate (Italian)
fad0824
@CRogos
[IMP] tracking_manager: Check records not empty
afdf4e3
@Ivorra78 @CRogos
Added translation using Weblate (Spanish)
a9b17f2
@CRogos
[IMP] tracking_manager: allow tracking readonly fields
c94076d
@CRogos
[IMP] tracking_manager: black, isort, prettier
51611e8
@CRogos
[MIG] tracking_manager: Migration to 17.0
c906b35
@CRogos CRogos force-pushed the 17.0-mig-tracking_manager branch from 358c4fe to c906b35 Compare May 2, 2024 12:55
@CRogos
Copy link
Contributor Author

CRogos commented May 2, 2024

@pedrobaeza rebased and fixed.

@pedrobaeza
Copy link
Member

pedrobaeza commented May 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 2, 2024

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2916-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4c468dd into OCA:17.0 May 2, 2024
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 2, 2024

Congratulations, your PR was merged at d2cdf00. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 17.0-mig-tracking_manager branch May 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@GuillemCForgeFlow GuillemCForgeFlow GuillemCForgeFlow approved these changes

@MohamedOsman7 MohamedOsman7 MohamedOsman7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

9 participants

@CRogos @OCA-git-bot @pedrobaeza @GuillemCForgeFlow @MohamedOsman7 @Kev-Roche @sebastienbeau @mymage @Ivorra78