-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[17.0] mig-excel_import_export #2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
5e7c69c to
e895d0f
Compare
|
Functional check is working as expected 👍 |
e895d0f to
1db35ce
Compare
Quick question: I see that many PRs are failing in the same module test (ERROR odoo odoo.addons.tracking_manager.tests.test_tracking_manager: FAIL: TestTrackingManager.test_not_tracked and ERROR odoo odoo.addons.tracking_manager.tests.test_tracking_manager: FAIL: TestTrackingManager.test_update_tracked ). Do you know what's happening here? |
|
@pedrobaeza hi Pedro, could you attend Josep's comment about the failing tests? Any idea? @Josep-s73 one last request would be to squash the administrative comments, as guided here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate |
|
Rebase the PR after #3020 is merged. /ocabot migration excel_import_export |
1db35ce to
7bfa83f
Compare
gaikaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work migrating this module. 🙏🏻
Code and Functional review.
Testing was done on runboat environment of this PR.
| string="Template", | ||
| required=True, | ||
| ondelete="cascade", | ||
| domain=lambda self: self._context.get("template_domain", []), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This template filtering doesn't seem to work.
When you have sale.order and account.move (invoice) templates, this should filter out specific templates according to the model, but instead shows all of them on both Sales and Invoices (see images below)
While testing, sometimes I would also get No template found Validation Error that comes from default_get method.
There must be something wrong with context generation and passing.
In debug mode, you can see that the domain isn't even set.

It would be very appreciated if you would add a test case for this. Mainly, checking if template_domain is generated and passed correctly.
* [ADD] v12 excel_import_export * Change from eval() to safe_evel() * Change variable to format to style, as fomat is a common python function :100644 100644 00ee3d9... e9e48d8... M excel_import_export/models/common.py :100644 100644 a215d29... 5b4d1fb... M excel_import_export/models/styles.py :100644 100644 ace11a3... 01e5b9f... M excel_import_export/models/xlsx_export.py :100644 100644 881b814... cadfb0f... M excel_import_export/models/xlsx_import.py :100644 100644 58689ee... 80490ce... M excel_import_export/models/xlsx_template.py :100644 100644 5c9c09a... a363ad1... M excel_import_export/views/xlsx_template_view.xml :100644 100644 475b518... 392fe6e... M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 4af9c51... 45ee33c... M excel_import_export_demo/report_sale_order/templates.xml :100644 100644 96157ea... 17d3964... M excel_import_export/__manifest__.py :100644 100644 00ee3d9... 51c2572... M excel_import_export/models/common.py :100644 100644 a215d29... 5b4d1fb... M excel_import_export/models/styles.py :100644 100644 ace11a3... 185a333... M excel_import_export/models/xlsx_export.py :100644 100644 881b814... cadfb0f... M excel_import_export/models/xlsx_import.py :100644 100644 58689ee... 80490ce... M excel_import_export/models/xlsx_template.py :100644 100644 5c9c09a... a363ad1... M excel_import_export/views/xlsx_template_view.xml :100644 100644 475b518... 392fe6e... M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 4af9c51... 45ee33c... M excel_import_export_demo/report_sale_order/templates.xml :100644 100644 96157ea... 933ce0d... M excel_import_export/__manifest__.py :100644 100644 00ee3d9... 51c2572... M excel_import_export/models/common.py :100644 100644 a215d29... 5b4d1fb... M excel_import_export/models/styles.py :100644 100644 ace11a3... 185a333... M excel_import_export/models/xlsx_export.py :100644 100644 881b814... cadfb0f... M excel_import_export/models/xlsx_import.py :100644 100644 58689ee... 80490ce... M excel_import_export/models/xlsx_template.py :100644 100644 5c9c09a... a363ad1... M excel_import_export/views/xlsx_template_view.xml :100644 100644 475b518... 392fe6e... M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 4af9c51... 45ee33c... M excel_import_export_demo/report_sale_order/templates.xml :100644 100644 96157ea 3b1217e M excel_import_export/__manifest__.py :100644 100644 00ee3d9 51c2572 M excel_import_export/models/common.py :100644 100644 a215d29 5b4d1fb M excel_import_export/models/styles.py :100644 100644 ace11a3 185a333 M excel_import_export/models/xlsx_export.py :100644 100644 881b814 cadfb0f M excel_import_export/models/xlsx_import.py :100644 100644 58689ee 80490ce M excel_import_export/models/xlsx_template.py :100644 100644 5c9c09a a363ad1 M excel_import_export/views/xlsx_template_view.xml :100644 100644 475b518 392fe6e M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 4af9c51 45ee33c M excel_import_export_demo/report_sale_order/templates.xml :100644 100644 96157ea fee958b M excel_import_export/__manifest__.py :100644 100644 00ee3d9 51c2572 M excel_import_export/models/common.py :100644 100644 a215d29 5b4d1fb M excel_import_export/models/styles.py :100644 100644 ace11a3 185a333 M excel_import_export/models/xlsx_export.py :100644 100644 881b814 cadfb0f M excel_import_export/models/xlsx_import.py :100644 100644 58689ee 80490ce M excel_import_export/models/xlsx_template.py :100644 100644 5c9c09a a363ad1 M excel_import_export/views/xlsx_template_view.xml :100644 100644 475b518 392fe6e M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 4af9c51 45ee33c M excel_import_export_demo/report_sale_order/templates.xml :100644 100644 96157ea fee958b M excel_import_export/__manifest__.py :100644 100644 00ee3d9 51c2572 M excel_import_export/models/common.py :100644 100644 a215d29 9738a3c M excel_import_export/models/styles.py :100644 100644 ace11a3 a7d6adc M excel_import_export/models/xlsx_export.py :100644 100644 881b814 12f9ca9 M excel_import_export/models/xlsx_import.py :100644 100644 70c3779 f123d2a M excel_import_export/models/xlsx_report.py :100644 100644 58689ee 578a1fd M excel_import_export/models/xlsx_template.py :100644 100644 5c9c09a a363ad1 M excel_import_export/views/xlsx_template_view.xml :100644 100644 800ea57 1807ea7 M excel_import_export/wizard/export_xlsx_wizard.py :100644 100644 febed8d 750dc17 M excel_import_export/wizard/import_xlsx_wizard.py :100644 100644 475b518 392fe6e M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 8e40a2d 2157489 M excel_import_export_demo/report_sale_order/report_sale_order.py :100644 100644 4af9c51 45ee33c M excel_import_export_demo/report_sale_order/templates.xml :100644 100644 96157ea fee958b M excel_import_export/__manifest__.py :100644 100644 00ee3d9 51c2572 M excel_import_export/models/common.py :100644 100644 a215d29 9738a3c M excel_import_export/models/styles.py :100644 100644 ace11a3 c7db3f9 M excel_import_export/models/xlsx_export.py :100644 100644 881b814 12f9ca9 M excel_import_export/models/xlsx_import.py :100644 100644 70c3779 f123d2a M excel_import_export/models/xlsx_report.py :100644 100644 58689ee 578a1fd M excel_import_export/models/xlsx_template.py :100644 100644 5c9c09a a363ad1 M excel_import_export/views/xlsx_template_view.xml :100644 100644 800ea57 1807ea7 M excel_import_export/wizard/export_xlsx_wizard.py :100644 100644 febed8d 750dc17 M excel_import_export/wizard/import_xlsx_wizard.py :100644 100644 475b518 392fe6e M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 8e40a2d 2157489 M excel_import_export_demo/report_sale_order/report_sale_order.py :100644 100644 4af9c51 45ee33c M excel_import_export_demo/report_sale_order/templates.xml :100644 100644 96157ea fee958b M excel_import_export/__manifest__.py :100644 100644 00ee3d9 51c2572 M excel_import_export/models/common.py :100644 100644 a215d29 9738a3c M excel_import_export/models/styles.py :100644 100644 ace11a3 c7db3f9 M excel_import_export/models/xlsx_export.py :100644 100644 881b814 12f9ca9 M excel_import_export/models/xlsx_import.py :100644 100644 70c3779 f123d2a M excel_import_export/models/xlsx_report.py :100644 100644 58689ee e3826e0 M excel_import_export/models/xlsx_template.py :000000 100644 00000000 34aa53b A excel_import_export/tests/__init__.py :000000 100644 00000000 1861868 A excel_import_export/tests/sale_order.xlsx :000000 100644 00000000 c848148 A excel_import_export/tests/test_xlsx_template.py :100644 100644 5c9c09a a363ad1 M excel_import_export/views/xlsx_template_view.xml :100644 100644 800ea57 1807ea7 M excel_import_export/wizard/export_xlsx_wizard.py :100644 100644 febed8d 750dc17 M excel_import_export/wizard/import_xlsx_wizard.py :100644 100644 475b518 392fe6e M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 8e40a2d 2157489 M excel_import_export_demo/report_sale_order/report_sale_order.py :100644 100644 4af9c51 45ee33c M excel_import_export_demo/report_sale_order/templates.xml :100644 100644 96157ea fee958b M excel_import_export/__manifest__.py :100644 100644 00ee3d9 51c2572 M excel_import_export/models/common.py :100644 100644 a215d29 9738a3c M excel_import_export/models/styles.py :100644 100644 ace11a3 c7db3f9 M excel_import_export/models/xlsx_export.py :100644 100644 881b814 12f9ca9 M excel_import_export/models/xlsx_import.py :100644 100644 70c3779 f123d2a M excel_import_export/models/xlsx_report.py :100644 100644 58689ee ed8c9fc M excel_import_export/models/xlsx_template.py :000000 100644 00000000 34aa53b A excel_import_export/tests/__init__.py :000000 100644 00000000 1861868 A excel_import_export/tests/sale_order.xlsx :000000 100644 00000000 69aa6ea A excel_import_export/tests/test_xlsx_template.py :100644 100644 5c9c09a a363ad1 M excel_import_export/views/xlsx_template_view.xml :100644 100644 800ea57 1807ea7 M excel_import_export/wizard/export_xlsx_wizard.py :100644 100644 febed8d 750dc17 M excel_import_export/wizard/import_xlsx_wizard.py :100644 100644 475b518 392fe6e M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 8e40a2d 2157489 M excel_import_export_demo/report_sale_order/report_sale_order.py :100644 100644 4af9c51 45ee33c M excel_import_export_demo/report_sale_order/templates.xml :100644 100644 96157ea fee958b M excel_import_export/__manifest__.py :100644 100644 00ee3d9 51c2572 M excel_import_export/models/common.py :100644 100644 a215d29 9738a3c M excel_import_export/models/styles.py :100644 100644 ace11a3 c7db3f9 M excel_import_export/models/xlsx_export.py :100644 100644 881b814 933d861 M excel_import_export/models/xlsx_import.py :100644 100644 70c3779 f123d2a M excel_import_export/models/xlsx_report.py :100644 100644 58689ee 1460473 M excel_import_export/models/xlsx_template.py :100644 100644 5c9c09a a363ad1 M excel_import_export/views/xlsx_template_view.xml :100644 100644 800ea57 1807ea7 M excel_import_export/wizard/export_xlsx_wizard.py :100644 100644 febed8d 750dc17 M excel_import_export/wizard/import_xlsx_wizard.py :100644 100644 a2d035e 9463f27 M excel_import_export_demo/__manifest__.py :100644 100644 475b518 e7f1255 M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 8e40a2d 2157489 M excel_import_export_demo/report_sale_order/report_sale_order.py :100644 100644 4af9c51 45ee33c M excel_import_export_demo/report_sale_order/templates.xml :000000 100644 00000000 79db62f A excel_import_export_demo/tests/__init__.py :000000 100644 00000000 1861868 A excel_import_export_demo/tests/sale_order.xlsx :000000 100644 00000000 c9733b9 A excel_import_export_demo/tests/test_common.py :000000 100644 00000000 9c94376 A excel_import_export_demo/tests/test_xlsx_import_export.py :000000 100644 00000000 730605c A excel_import_export_demo/tests/test_xlsx_template.py :100644 100644 96157ea fee958b M excel_import_export/__manifest__.py :100644 100644 00ee3d9 51c2572 M excel_import_export/models/common.py :100644 100644 a215d29 9738a3c M excel_import_export/models/styles.py :100644 100644 ace11a3 c7db3f9 M excel_import_export/models/xlsx_export.py :100644 100644 881b814 933d861 M excel_import_export/models/xlsx_import.py :100644 100644 70c3779 f123d2a M excel_import_export/models/xlsx_report.py :100644 100644 58689ee 1460473 M excel_import_export/models/xlsx_template.py :100644 100644 5c9c09a a363ad1 M excel_import_export/views/xlsx_template_view.xml :100644 100644 800ea57 1807ea7 M excel_import_export/wizard/export_xlsx_wizard.py :100644 100644 febed8d 750dc17 M excel_import_export/wizard/import_xlsx_wizard.py :100644 100644 a2d035e 9463f27 M excel_import_export_demo/__manifest__.py :100644 100644 475b518 e7f1255 M excel_import_export_demo/import_export_sale_order/templates.xml :100644 100644 8e40a2d 2157489 M excel_import_export_demo/report_sale_order/report_sale_order.py :100644 100644 4af9c51 45ee33c M excel_import_export_demo/report_sale_order/templates.xml :000000 100644 00000000 79db62f A excel_import_export_demo/tests/__init__.py :000000 100644 00000000 1861868 A excel_import_export_demo/tests/sale_order.xlsx :000000 100644 00000000 bb3ea32 A excel_import_export_demo/tests/test_common.py :000000 100644 00000000 9c94376 A excel_import_export_demo/tests/test_xlsx_import_export.py :000000 100644 00000000 730605c A excel_import_export_demo/tests/test_xlsx_template.py
wrong use of dict.iteritems() for python3
Fix Import Excel wizard, cannot download template as in v12 core Odoo prevent download default binary.
Add report action feature and new examples
Currently translated at 81.2% (156 of 192 strings) Translation: server-tools-16.0/server-tools-16.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-excel_import_export/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-excel_import_export/
Currently translated at 100.0% (193 of 193 strings) Translation: server-tools-16.0/server-tools-16.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-excel_import_export/es/
Currently translated at 80.8% (156 of 193 strings) Translation: server-tools-16.0/server-tools-16.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-excel_import_export/it/
Currently translated at 86.5% (167 of 193 strings) Translation: server-tools-16.0/server-tools-16.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-excel_import_export/it/
Currently translated at 100.0% (193 of 193 strings) Translation: server-tools-16.0/server-tools-16.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-excel_import_export/it/
Currently translated at 100.0% (193 of 193 strings) Translation: server-tools-16.0/server-tools-16.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-excel_import_export/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-excel_import_export/
Currently translated at 100.0% (194 of 194 strings) Translation: server-tools-16.0/server-tools-16.0-excel_import_export Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-excel_import_export/it/
7bfa83f to
54b5bbc
Compare
|
@gaikaz @nobuQuartile Added the commented commits, and also fixed the code so that when the wizard opens we only have the model templates You can check it |
|
Oh, I've tested the import. I suspect, I'm missing something. |
54b5bbc to
0449060
Compare
…l related templates for export action Before this commit, when two templates exist for the same model, clicking "ADD EXPORT ACTION" for each template creates separate server actions for each. As a result, if multiple templates are created for the same model, numerous server actions with the label "Export Excel" will accumulate for that model. With this commit, if two templates exist for the same model and "ADD EXPORT ACTION" is clicked for each, they will now share a single server action. Users can then select templates from within the "Export Excel" wizard. Clicking "REMOVE EXPORT ACTION" on a template will remove only that template from the "Export Excel" selection. The server action itself will be deleted only when no templates use it for export.
This commit fixes issue of finding multiple records across all companies during import when they have same record name. Previously, importing with sudo could bypass multi-company record rules.
0449060 to
14e15bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Functional review ok



Standard migration 17.0