Fix bug that made previous images to disappear. #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why it has to be done in pre instead of post? |
Member
Author
|
Because on post images are already gone. |
Member
|
OK, I understand. What about the signature change? |
Member
Author
|
Signature? |
Member
|
The signature is the number and the name of the arguments of a method |
Member
Author
|
ah sorry, pre_init_hooks lack the registry argument. |
Member
|
OK, thanks for the explanation. I didn't remember that. 👍 I'm going to fast-track to avoid people that starts using this module uses this wrong hook. |
pedrobaeza
added a commit
that referenced
this pull request
Mar 11, 2016
Fix bug that made previous images to disappear.
Member
Author
|
Thank you 😉 |
StefanRijnhart
pushed a commit
to StefanRijnhart/server-tools
that referenced
this pull request
Feb 26, 2017
…page_onclose [ADD] run onclose handler if we got one
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (11.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OCA/product-attribute#135 (comment). (when merged).
Although this is a breaking change, it current submodules don't use hooks (the only breaking part). The current implementation was useless anyway.
@rafaelbn @carlos-incaser