[MIG] Migrate auditlog module from 8.0 to 9.0 #454

holdenrehg · 2016-06-12T23:23:24Z

The majority of the module was already following new api conventions and not using any deprecated methods, so there was only minor clean up to move to over to 9.0

Update documentation to point to the new auditlog menu locations. These were changed because the 8.0 version was referencing menus that do not exist in 9.0
Change version from 8.0.1.0.0 to 9.0.1.0.0
Make the module installable again
Remove an unused parameter from pre-migration.py for versioning
Update classes to follow OCA new api conventions, camel case instead of snake case
Fix typos and remove commented out blocks of code that were irrelevant

- Update documentation to point to the new auditlog menu locations. These were changed because the 8.0 version was referencing menus that do not exist in 9.0 - Change version from 8.0.1.0.0 to 9.0.1.0.0 - Make the module installable again - Remove an unused parameter from pre-migration.py for versioning - Update classes to follow OCA new api conventions, camel case instead of snake case - Fix typos and remove commented out blocks of code that were irrelevant

oca-clabot · 2016-06-12T23:23:26Z

Hey @holdenrehg, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

@holdenrehg (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

coveralls · 2016-06-12T23:29:08Z

Coverage increased (+3.7%) to 76.271% when pulling a7e708e on holdenrehg:feature/9.0 into 1e935c0 on OCA:9.0.

holdenrehg · 2016-06-12T23:31:31Z

Here is a reference to my CLA signature odoo/odoo#12305

moylop260 · 2016-06-13T02:27:04Z

@holdenrehg
Thanks for you contribution.

Here is a reference to my CLA signature odoo/odoo#12305

This one is CLA of odoo. Could you sign your CLA of oca https://odoo-community.org/page/cla too?

moylop260 · 2016-06-13T02:28:59Z

Could you check the license?

auditlog/__openerp__.py:22: [C8102(manifest-required-key), ] Missing required key "license" in manifest file

More info here

…ields These were updated to follow OCA conventions. - License set to AGPL-3 - Images set to empty array

holdenrehg · 2016-06-13T03:37:05Z

@moylop260 Checked and updated the license field. See here for the commit.

coveralls · 2016-06-13T03:39:41Z

Coverage increased (+3.7%) to 76.271% when pulling 233bb87 on holdenrehg:feature/9.0 into 1e935c0 on OCA:9.0.

moylop260 · 2016-06-13T04:51:41Z

Thank you
After CLA detail... LGTM

hbrunn · 2016-06-13T05:28:03Z

you should follow the procedure outlined in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0#howto to get 8.0's commits. This allows us to simply cherry pick changes afterwards and keeps history intact.

holdenrehg · 2016-06-13T11:22:26Z

Sounds good @hbrunn I'll pull in that 8.0 history and update the PR.

holdenrehg · 2016-06-14T14:56:04Z

@hbrunn It appears that all the 8.0 commit history is already there. There was an updated translations file that I pulled from the 12th after I migrated the module.

hbrunn · 2016-06-14T15:02:05Z

you seem to run the commands mentioned above on your current branch, this won't give you the desired results. You need to start out from an upstream 9.0 branch, and then do do the stuff so that the commit history includes all of those: https://github.com/OCA/server-tools/commits/8.0/auditlog

I also see that there are some commits that make the module better, but are not reflected in this PR, like 3f9152c

…ther minor fixes

…itlog.log' model (standard 'create_date' field is used instead)

…S.txt file removed

holdenrehg · 2016-06-14T15:55:58Z

@hbrunn So is the proper way to perform the actions on an upstream branch and then merge into this PR? It will add 70+ commits to this PR. Want to make sure I'm handling this the correct way according to OCA conventions.

hbrunn · 2016-06-14T16:07:26Z

yes, that's exactly what we want

Just do all of this in a fresh branch and push overwrite this one. Or just close this PR and create a new one with your new branch.

holdenrehg · 2016-06-14T16:29:45Z

Ah thanks @hbrunn

sebalix · 2016-06-14T16:37:56Z

auditlog/README.rst

+
+Get the details:
+
+.. image:: /auditlog/static/description/log.png


I set all these image URLs in my last PR, but it seems they do not work properly on apps.odoo.com (https://apps.odoo.com/apps/modules/8.0/auditlog/). We should change them to relative ones like static/description/IMAGE.png in order to have them displayed.

Relative paths do not work when testing. I'll leave these as absolute for now.

hbrunn · 2016-06-14T17:23:08Z

auditlog/__openerp__.py

    'author': "ABF OSIELL,Odoo Community Association (OCA)",
+    'license': "AGPL-3",
    'website': "http://www.osiell.com",
+    'license': 'AGPL-3',


two is a crowd already: https://travis-ci.org/OCA/server-tools/jobs/137559872#L433

hbrunn · 2016-06-14T17:24:41Z

runbot error unrelated

holdenrehg · 2016-06-24T18:49:05Z

@hbrunn stripped out that duplicated license key, also thanks for mentioning unrelated runbot errors. Saw the same, related to other modules.

sebalix · 2016-06-25T12:18:26Z

Tested on Runbot, 👍

sebalix · 2016-06-26T09:44:29Z

auditlog/migrations/8.0.1.0/pre-migration.py



-def migrate(cr, version):
+def migrate(cr):


I did not see this. We should not change the signature of the method here, even if the version parameter is not used. It seems that the migrate method is always called with this parameter: https://github.com/odoo/odoo/blob/9.0/openerp/modules/migration.py#L152

In fact, this file should be totally removed, as the migration doesn't apply to the version 9.

It's right.

…is not required for version 9

…nit hook exists any more

moylop260 · 2016-06-27T18:15:51Z

auditlog/models/http_request.py

+    _order = "create_date DESC"
+    _rec_name = 'display_name'
+
+    display_name = fields.Char(u"Name", compute="_display_name")


s/_display_name/_compute_display_name/g

any reason not to overwrite name_get instead? This will be the display name by default, with the added benefit that name_get also returns something sensible. Then you also don't need to set _rec_name. cf https://github.com/OCA/OCB/blob/9.0/openerp/models.py#L1664

What's better in this scenario? name_get seems to be less elegant if you still keep the computed display_name field. If you get rid of display_name and compute directly in name_get that has worse performance since it will be computed on every view load that has this model defined.

class AuditlogHTTPRequest(models.Model): ... display_name = fields.Char(u"Name", compute="_compute_display_name") @api.multi @api.depends('create_date', 'name') def _compute_display_name(self): for httprequest in self: create_date = fields.Datetime.from_string(httprequest.create_date) tz_create_date = fields.Datetime.context_timestamp( httprequest, create_date) httprequest.display_name = u"%s (%s)" % ( httprequest.name or '?', fields.Datetime.to_string(tz_create_date)) @api.multi def name_get(self): res = [] for request in self: res += [(request.id, request.display_name)] return res

Is this a blocking point to migrate on 9.0? At best rename _display_name to _compute_display_name.

pedrobaeza · 2016-10-12T08:18:54Z

Please rebase the branch to make it mergeable

pedrobaeza · 2016-11-13T13:42:09Z

Superseeded by #603

Syncing from upstream OCA/server-tools (9.0)

pedrobaeza mentioned this pull request Jun 12, 2016

Migration to version 9.0 #271

Closed

59 tasks

[UPD] Updated the __openerp__.xml to include the license and images f…

233bb87

…ields These were updated to follow OCA conventions. - License set to AGPL-3 - Images set to empty array

hbrunn added needs fixing needs review labels Jun 13, 2016

hbrunn added this to the 9.0 milestone Jun 13, 2016

OCA Transbot updated translations from Transifex

e0284f1

sebalix and others added 11 commits June 14, 2016 10:20

[IMP] Module 'auditlog' - Add 'name' attributes on some filters and o…

e6eb60d

…ther minor fixes

[IMP] Module 'auditlog' - Removed the 'timestamp' field from the 'aud…

bf62fba

…itlog.log' model (standard 'create_date' field is used instead)

[IMP] Module 'auditlog' - README.rst updated (based on the OCA template)

6bdee78

[IMP] ignore rules for nonexisting objects

ce173d3

[ADD] init hook to migrate from audittrail

70cdb3b

[FIX] also migrate id sequences

e52bab7

[IMP] Module 'auditlog' - Contributors updated in README.rst + AUTHOR…

d06543d

…S.txt file removed

[ADD] change xmlids of legacy rules to point to auditlog.rule

4536edf

[IMP] use new import of _, SUPERUSER_ID

4b2d3ae

[ADD] allow overriding modules to pass additional log values

17daf92

[IMP] cache model and field ids

01b0d2c

oca-transbot and others added 10 commits June 14, 2016 10:48

OCA Transbot updated translations from Transifex

5c96df5

OCA Transbot updated translations from Transifex

1ae139e

OCA Transbot updated translations from Transifex

afcae78

OCA Transbot updated translations from Transifex

d6539fa

OCA Transbot updated translations from Transifex

b174a16

OCA Transbot updated translations from Transifex

caa9ce3

[IMP] auditlog - Icon added + README updated (screenshots)

d2ec9d2

OCA Transbot updated translations from Transifex

27b1d15

OCA Transbot updated translations from Transifex

f38edf4

[UPD] auditlog module - Merge commit from 8.0

295a36d

sebalix reviewed Jun 14, 2016
View reviewed changes

hbrunn removed the needs fixing label Jun 14, 2016

hbrunn reviewed Jun 14, 2016
View reviewed changes

[UPD] auditlog module, Remove duplicate license key from openerp config

9eff852

sebalix reviewed Jun 26, 2016
View reviewed changes

holdenrehg added 2 commits June 27, 2016 09:23

[DEL] auditlog: Remove migration from audittrail functionality, this …

856c84c

…is not required for version 9

[DEL] auditlog: Remove pre_init_hook reference from openerp, no pre_i…

9ebaa60

…nit hook exists any more

moylop260 reviewed Jun 27, 2016
View reviewed changes

sebalix approved these changes Oct 12, 2016

View reviewed changes

sebalix mentioned this pull request Nov 13, 2016

[MIG] 9.0 - auditlog #603

Merged

pedrobaeza closed this Nov 13, 2016

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#454 from OCA/9.0

686b937

Syncing from upstream OCA/server-tools (9.0)


		Get the details:

		.. image:: /auditlog/static/description/log.png

Uh oh!

[MIG] Migrate auditlog module from 8.0 to 9.0 #454

[MIG] Migrate auditlog module from 8.0 to 9.0 #454

Uh oh!

Conversation

holdenrehg commented Jun 12, 2016

Uh oh!

oca-clabot commented Jun 12, 2016

Uh oh!

coveralls commented Jun 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

holdenrehg commented Jun 12, 2016

Uh oh!

moylop260 commented Jun 13, 2016

Uh oh!

moylop260 commented Jun 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

holdenrehg commented Jun 13, 2016

Uh oh!

coveralls commented Jun 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moylop260 commented Jun 13, 2016

Uh oh!

hbrunn commented Jun 13, 2016

Uh oh!

holdenrehg commented Jun 13, 2016

Uh oh!

holdenrehg commented Jun 14, 2016

Uh oh!

hbrunn commented Jun 14, 2016

Uh oh!

holdenrehg commented Jun 14, 2016

Uh oh!

hbrunn commented Jun 14, 2016

Uh oh!

holdenrehg commented Jun 14, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hbrunn commented Jun 14, 2016

Uh oh!

holdenrehg commented Jun 24, 2016

Uh oh!

sebalix commented Jun 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Oct 12, 2016

Uh oh!

pedrobaeza commented Nov 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

coveralls commented Jun 12, 2016 •

edited

Loading

moylop260 commented Jun 13, 2016 •

edited

Loading

coveralls commented Jun 13, 2016 •

edited

Loading