Skip to content

Conversation

@serpentcs-dev1
Copy link
Member

  • Migrated base_search_fuzzy module to v9

Copy link
Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested with OCA/social#143

@JordiBForgeFlow
Copy link
Member

@lreficent @aheficent, can you test, together with OCA/social#143?

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with OCA/social#143 👍

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with OCA/social#143 👍

@JordiBForgeFlow
Copy link
Member

@christophlsa are you ok to merge?

@pedrobaeza
Copy link
Member

@jbeficent, please squash commits by author first.

@JordiBForgeFlow
Copy link
Member

@pedrobaeza We have only added 1 commit to migrate to v9. The others are commits from v8. Shall we still squash??

@pedrobaeza
Copy link
Member

Yes, please, because this commit story is meaningless in this branch (all the "OCA Transbot..." for example, you want final translations, not all the middle diffs). The same can apply for the consecutive code refinements made by the same author (probably from the 8.0 PR, that wasn't squashed there). You already have that history on 8.0 branch, that is where matters. Here, you only need to respect attribution.

@JordiBForgeFlow
Copy link
Member

@darshan-serpent Can you take care of the request from @pedrobaeza ?

@JordiBForgeFlow
Copy link
Member

@pedrobaeza. I see some changes proposed to files outside this module, but seem to be the result of migrating commit history from v8. They are harmless changes. IMHO this one is ready to merge.

@JordiBForgeFlow
Copy link
Member

cc @pedrobaeza Can we merge?

@dreispt dreispt merged commit 8e332e3 into OCA:9.0 Jan 13, 2017
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (14.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants