-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[9.0] [ADD] base search fuzzy #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
serpentcs-dev1
commented
Dec 26, 2016
- Migrated base_search_fuzzy module to v9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tested with OCA/social#143
|
@lreficent @aheficent, can you test, together with OCA/social#143? |
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with OCA/social#143 👍
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with OCA/social#143 👍
|
@christophlsa are you ok to merge? |
|
@jbeficent, please squash commits by author first. |
|
@pedrobaeza We have only added 1 commit to migrate to v9. The others are commits from v8. Shall we still squash?? |
|
Yes, please, because this commit story is meaningless in this branch (all the "OCA Transbot..." for example, you want final translations, not all the middle diffs). The same can apply for the consecutive code refinements made by the same author (probably from the 8.0 PR, that wasn't squashed there). You already have that history on 8.0 branch, that is where matters. Here, you only need to respect attribution. |
|
@darshan-serpent Can you take care of the request from @pedrobaeza ? |
8481aac to
8b77d60
Compare
…t tests, added translations, added access permissions, moved the monkey patching to method _register_hook of ir.model and fixed _auto_init, added README, cleaned up some aprts
71dca30 to
1a56951
Compare
|
@pedrobaeza. I see some changes proposed to files outside this module, but seem to be the result of migrating commit history from v8. They are harmless changes. IMHO this one is ready to merge. |
|
cc @pedrobaeza Can we merge? |
Syncing from upstream OCA/server-tools (14.0)