[16.0][FIX] email_template_qweb: use language-aware env for rendering QWeb

[KKamaa]

fix bug where in email_template_qweb module: the QWeb renderer (ir.qweb) is instantiated once from the original environment (self.env) before the code switches into the per-language context:

• Subject is rendered via the "normal" mail.template rendering path that uses the per-language self_with_lang context -> it follows template.lang.
• Body is rendered by ir.qweb._render(...) using an IrQweb recordset created before lang was applied -> it keeps whatever env.lang was at the moment generate_email() started (e.g. the website request language, current user language, etc.), which explains the "random" English/Dutch mix.

[thomaspaulb]

Code approved, just the commit message should change to the OCA standard:

[FIX] email_template_qweb: use language-aware env for rendering QWeb

More detailed information... (maybe can leave out in this case, summary is clear)

[NL66278]

Bit overkill to spread [res_id] over three lines.

[KKamaa]

It looks that way due to the pylint but the res_id used is from the for loop.

[NL66278]

Maybe I was not clear, I just meant that lines 48 - 50 could be on one line, making it all a bit more compact and readable.

[KKamaa]

updated the readability on the lines affected

[NL66278]

👍 One minor remark but for the rest LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[thomaspaulb]

@OCA/social-maintainers This is ready for merge

[NL66278]

@KKamaa Please remove the Draft: status of this PR, as that might stop people from merging.

[NL66278]

👍 Already looked good. Now even better ;-)