[16.0] fs_attachment: fix meaningful name rewriting

[len-foss]

This fix the name rewriting in case the storage is "directory name optimized".

It adds a test to ensure that the name is consistently used between write and read.

Closes #285

[OCA-git-bot]

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

[lmignon]

Thank you @len-foss LGTM (Code review)
I wonder if this behaviour also works correctly when using the 'file like' api to modify the contents of the attachment....

with attachment.open("wb") as f:
    f.write(...)

Nevertheless, can you add a file named 312.bugfix into the fs_attachment/readme/newsfragment directory to describe the change in an 'end user 'oriented way. This description will be add to the history section of the module description at merge

[len-foss]

I'm very confused, as the newly added test breaks on the write, and only so if other tests from the same file (test_fs_attachment) are run. The way it breaks is also very strange:

FileNotFoundError: [Errno 2] No such file or directory: '/github/home/.local/share/Odoo/filestore/odoo/storage//tmp/tmpq6abj5qo/github/home/.local/share/Odoo/filestore/odoo/storage//te/st/test.txt'

Let's take a bit more time to understand where the issue is coming from, unless you already have some pointer?

[lmignon]

I'm very confused, as the newly added test breaks on the write, and only so if other tests from the same file (test_fs_attachment) are run. The way it breaks is also very strange:

FileNotFoundError: [Errno 2] No such file or directory: '/github/home/.local/share/Odoo/filestore/odoo/storage//tmp/tmpq6abj5qo/github/home/.local/share/Odoo/filestore/odoo/storage//te/st/test.txt'

Let's take a bit more time to understand where the issue is coming from, unless you already have some pointer?

The tests are failing due to the env cleanup at transaction rollback after each test. Indeed, the fs.storage backend inherit from the server.env.mixin. Therefore some fields are pseudo computed fields and need to be reset before running each test. To fix your issue, you need to update your created fs.storage record into the setup method....

def setUp(self)::
    super().setUp()
    self.backend_optimized = write(
            {
                "protocol": "file",
                "code": "tmp_opt",
                "directory_path": temp_dir,
                "optimizes_directory_path": True,
            }
        )

[len-foss]

Oh, thank you very much!
I see, that also explains why I had to create the other backend, reusing the other made the tests break unexplainably in a similar fashion.

We should be good now then :-)

[lmignon]

A little comment otherwise LGTM (Code review).

Thank you for the contrib. Don't forget to add you name into the contributor list 😏

[len-foss]

All right. I have added this to the test and a bit more explanations to make it easier to check the assumptions.

[lmignon]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-312-by-lmignon-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at ad8a4d3. Thanks a lot for contributing to OCA. ❤️