[16.0][IMP] fs_storage: pattern matching should only apply to file name, not full path#317
Merged
OCA-git-bot merged 1 commit intoOCA:16.0from Feb 21, 2024
Merged
Conversation
tuantrantg
changed the title
simahawk
reviewed
Jan 9, 2024
Contributor
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
A remark for the commit msg
[IMP or FIX] fs_storage: improve/fix find_files pattern match
bla bla explanation
| regex = re.compile(pattern) | ||
| for file_path in self.fs.ls(relative_path, detail=False): | ||
| if regex.match(file_path): | ||
| # fs.ls returns a relative path |
Contributor
There was a problem hiding this comment.
As this method is deprecated, does it makes sense to improve it? Unless, this is a fix...
…should only apply to file name, not full path
tuantrantg
force-pushed
the
16.0-imp-fs_storage
branch
from
12f4453 to
62a7b30
Compare
lmignon
approved these changes
Feb 21, 2024
Contributor
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at cb15c6f. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.