[MIG] fs_storage: Migration to 18.0#399
Merged
OCA-git-bot merged 54 commits intoOCA:18.0from Oct 28, 2024
Merged
Conversation
qgroulard
force-pushed
the
18.0-mig-fs_storage
branch
from
2cb6a94 to
5d46ddd
Compare
Member
|
/ocabot migration fs_storage Can you cherry-pick the commits from #397 ? |
qgroulard
force-pushed
the
18.0-mig-fs_storage
branch
from
5d46ddd to
cf67143
Compare
1 task
lmignon
approved these changes
Oct 7, 2024
lmignon
approved these changes
Oct 7, 2024
Contributor
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
Code review only, no tests
This addon define a new model 'fs.storage' used to get access to a filesystem storage (ftp, sftp, s3, azure, ...) through an unified interface provided by the 'fsspec' python library (https://filesystem-spec.readthedocs.io/en/latest)
…dav. It is not possible to specify a tuple in json
Add history for commit included from OCA#285 and the author to the contributors list
Before this change, users with basic access rights was no more able to create an attachment. The problem was caused by the need to access system information to determine in which file system the attachment should be created, when this sensitive information is not accessible to everyone. The change consists of reading this information in sudo to bypass this security restriction in this specific context.
Currently translated at 100.0% (37 of 37 strings) Translation: storage-16.0/storage-16.0-fs_storage Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/es/
Currently translated at 100.0% (37 of 37 strings) Translation: storage-16.0/storage-16.0-fs_storage Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/es/
Currently translated at 100.0% (37 of 37 strings) Translation: storage-16.0/storage-16.0-fs_storage Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/es/
Currently translated at 100.0% (37 of 37 strings) Translation: storage-16.0/storage-16.0-fs_storage Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/it/
Before the change, reading the options protocol might not be in sync with the record protocol. This is particularly the case if the record is save in the middle of editing as the value resets, which can be quite confusing.
Currently translated at 92.1% (35 of 38 strings) Translation: storage-17.0/storage-17.0-fs_storage Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_storage/it/
Currently translated at 92.1% (35 of 38 strings) Translation: storage-17.0/storage-17.0-fs_storage Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_storage/it/
Currently translated at 100.0% (38 of 38 strings) Translation: storage-17.0/storage-17.0-fs_storage Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_storage/es/
Since fsspec/filesystem_spec@da77548 it is necessary to set in make_path_posix() only 1 argument
Currently translated at 100.0% (38 of 38 strings) Translation: storage-17.0/storage-17.0-fs_storage Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_storage/it/
Currently translated at 100.0% (38 of 38 strings) Translation: storage-17.0/storage-17.0-fs_storage Translate-URL: https://translation.odoo-community.org/projects/storage-17-0/storage-17-0-fs_storage/zh_CN/
Since protocol is under server_environment control, it seems its default value takes priority over a value set in an XML record. Since it does really make much sense to create a storage backend without specifying the protocol, we remove the default value.
…should only apply to file name, not full path
This is necessary for non admin users to access file systems, for instance for attachments. This went unnoticed so far presumably because the filesystem is cached and likely accessed by the server during server bootstrap.
sbidoul
force-pushed
the
18.0-mig-fs_storage
branch
from
cf67143 to
0c56379
Compare
Member
|
Rebased to pick-up the dotfiles update. The new xml autoformatter cleaned up one xml file a bit. |
Contributor
|
/ocabot merge nobump |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 6881734. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including commits from #397