[19.0][MIG] fs_attachment Migration 19.0#527
Conversation
fcbbd32 to
8f17709
Compare
8f17709 to
70cb033
Compare
CRogos
left a comment
There was a problem hiding this comment.
I think you need to restart following: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0
The commit history is not preserved.
|
The PR looks fine (19.0 was branched off 18.0, so only the migration commits appear here), but it misses a test-requirements.txt to reference the unmerged fs_storage PR. |
|
@cyrilmanuel can you add a |
|
There are also a few pre-commit issues that need addressing. The empty domains errors in pylint can be ignored with a |
89bdff1 to
718de03
Compare
|
Did few fixes on cyrilmanuel#2 |
fixup! fixup! [19.0][MIG] fs_attachment Migration 19.0
|
@cyrilmanuel some fixes here cyrilmanuel#3 |
|
@cyrilmanuel I moved forward with your great work in #544 .... |
depend on #524