[FIX] fs_attachment: ignore missing files when migrating to object storage#555
Open
ivantodorovich wants to merge 1 commit intoOCA:19.0from
Open
[FIX] fs_attachment: ignore missing files when migrating to object storage#555ivantodorovich wants to merge 1 commit intoOCA:19.0from
ivantodorovich wants to merge 1 commit intoOCA:19.0from
Conversation
Contributor
|
Hi @lmignon, |
ivantodorovich
force-pushed
the
19.0-fix-fs-attachment-force-ignore-missing
branch
2 times, most recently
from
e6074ca to
a28157f
Compare
…orage In the event an attachment's file is not present in the filestore, Odoo would log an error and return an empty file content: b'' upon reading it's `datas`. During a migration to the object storage, that would cause an empty file to be uploaded to the object storage, and the original attachment's checksum to be overwritten with the checksum of the empty file. This commit fixes this by checking if the file exists before attempting to migrate it, ignoring it otherwise.
ivantodorovich
force-pushed
the
19.0-fix-fs-attachment-force-ignore-missing
branch
from
a28157f to
cfbf6dc
Compare
gurneyalex
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event an attachment's file is not present in the filestore, Odoo would log an error and return an empty file content:
b''upon reading it'sdatas.During a migration to the object storage, that would cause an empty file to be uploaded to the object storage, and the original attachment's checksum to be overwritten with the checksum of the empty file.
This commit fixes this by checking if the file exists before attempting to migrate it, ignoring it otherwise.