-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[16.0] [IMP] web_responsive showing main menu when no application is selected #2816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
5640a42 to
86975f6
Compare
|
Code OK. But idk how to "solve" the tests... |
86975f6 to
d5753de
Compare
Jaimermaccione
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Functional review on runboat
pedrobaeza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be something optional.
|
Hi @pedrobaeza , what problem do you see in setting this as default behavior o the module? |
|
For several reasons:
If you assure that there are no problems with points 2 and 3, then 1 can be ignored. |
|
Thanks @eLBati. |
|
I would hide the top left button after login. |
d5753de to
0907812
Compare



See