[add] cms_form + cms_form_example #9

simahawk · 2017-02-16T13:16:29Z

CMS Form

Basic website contents form framework. Allows to define front-end forms for every models in a simple way.

If you are tired of re-defining every time an edit form or a search form for your odoo website,
this is the module you are looking for.

Features

automatic form generation (create, write, search)
automatic route generation (create, write, search)
automatic machinery based on fields' type:
- widget rendering
- field value load (from existing instance or from request)
- field value extraction (from request)
- field value write (to existing instance)
highly customizable
works with every odoo model
works also without any model
add handy attributes to models inheriting from website.published.mixin:
- cms_add_url: lead to create form view. By default /cms/form/create/my.model
- cms_edit_url: lead to edit form view. By default /cms/form/edit/my.model/model_id
- cms_search_url: lead to search form view. By default /cms/form/search/my.model

(extracted from official README)

coveralls · 2017-02-16T14:18:11Z

Coverage decreased (-10.3%) to 84.748% when pulling 3d73c7b on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

coveralls · 2017-02-16T14:18:11Z

Coverage decreased (-10.3%) to 84.748% when pulling 3d73c7b on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

simahawk · 2017-02-16T14:37:23Z

@lasley @yajo as usual, when you have time.... :)

PS: is it possible to configure test coverage checks to ignore some stuff, like cms_form_example module?

lasley · 2017-02-17T17:06:33Z

PS: is it possible to configure test coverage checks to ignore some stuff, like cms_form_example module?

Few different ways - in your instance prolly the coveragerc file would be best.

My warning is to not go excluding things all over the place because it's really just covering up a problem. Anything not tested is a ticking timebomb IMO.

That said, we're definitely fine ignoring an example module.

coveralls · 2017-02-17T17:30:17Z

Coverage decreased (-10.3%) to 84.748% when pulling 1144cd1 on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

lasley · 2017-02-17T17:46:58Z

.coveragerc

@@ -0,0 +1,4 @@
+[run]


Take a look at https://github.com/LasLabs/python-cfssl/blob/master/.coveragerc

You want report section

well, the docs do not mention [report] here https://coverage.readthedocs.io/en/coverage-4.2/source.html#execution
anyway, I updated it as per your example, but is still looking for cms_form_example.
Better look at this tomorrow, instead of checking it in the middle of my baby's bath 😄

I looked further and it looks like coveragerc isn't an option because the template is being used instead. It would probably be best to just use

# pragma: no cover

near the top of the python files then 😦

coveralls · 2017-02-17T19:02:35Z

Coverage decreased (-10.3%) to 84.748% when pulling 05f2816 on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

lasley · 2017-02-28T19:45:10Z

@tedsalmon please review

tedsalmon

👍 Awesome work! I have some minor review items, mostly import related stuff that caught my eye :)

tedsalmon · 2017-03-02T00:49:34Z

cms_form/models/cms_form.py

+# Copyright 2017 Simone Orsi
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from openerp import models


A little nit picky but these imports are not ordered alphabetically as OCA guidelines ask. Perhaps you'd consider importing in a single line?

from openerp import _, exceptions, models

tedsalmon · 2017-03-02T00:51:29Z

cms_form/models/cms_form_mixin.py

+from ..utils import DEFAULT_LOADERS, DEFAULT_EXTRACTORS
+from ..import widgets
+
+import inspect


These imports should be above the Odoo import

tedsalmon · 2017-03-02T00:53:12Z

cms_form/models/cms_form_mixin.py

+                value = extractor(self, fname, value, **request_values)
+            if value is None:
+                # we assume we do not want to override the field value.
+                # a tipical example is an image field.


s/tipical/typical

tedsalmon · 2017-03-02T00:54:40Z

cms_form/models/cms_search_form.py

+    def form_search_domain(self, search_values):
+        """Build search domain.
+
+        TODO...


What's TODO here?

well: explain how we build domain and maybe improve it a little bit.

tedsalmon · 2017-03-02T00:55:20Z

cms_form/models/test_models.py

+# Copyright 2017 Simone Orsi
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from openerp import models


Alphabetical import order, again :)

tedsalmon · 2017-03-02T00:57:50Z

cms_form/tests/__init__.py

+from . import test_form_search
+from . import test_form_render
+from . import test_loaders
+from . import test_controllers


Import alphabetically :)

tedsalmon · 2017-03-02T00:58:06Z

cms_form/tests/test_controllers.py

+from .common import fake_request
+from .common import FormHttpTestCase
+from ..controllers import main
+import mock


These should be above your local imports

@tedsalmon tnx! I'll go trough them.

coveralls · 2017-03-02T13:59:39Z

Coverage decreased (-10.2%) to 84.82% when pulling 26ed9c4 on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

coveralls · 2017-03-02T13:59:40Z

Coverage decreased (-10.2%) to 84.82% when pulling 26ed9c4 on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

coveralls · 2017-03-02T14:01:53Z

Coverage decreased (-10.2%) to 84.82% when pulling 26ed9c4 on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

coveralls · 2017-03-06T17:09:11Z

Coverage decreased (-10.4%) to 84.579% when pulling 7dc324b on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

guewen

Wow

guewen · 2017-03-10T09:37:44Z

cms_form/README.rst

+            if extra_values.get('notify_partner'):
+                # do what you want here...
+
+``notifiy_partner`` will be included into the form but it will be discarded on create and write.


s/notifiy/notify/g

See OCA/website-cms#9 (review)

coveralls · 2017-03-10T14:10:08Z

Coverage decreased (-10.4%) to 84.579% when pulling 3546f26 on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

coveralls · 2017-03-10T14:10:09Z

Coverage decreased (-10.4%) to 84.579% when pulling 3546f26 on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

coveralls · 2017-03-10T14:12:12Z

Coverage decreased (-10.4%) to 84.579% when pulling 3546f26 on simahawk:add-cms_form-PR into 4514cbe on OCA:9.0.

lasley · 2017-03-10T16:10:58Z

@simahawk - Did you have any plans to up the test coverage?

lasley · 2017-05-15T15:45:54Z

@simahawk - I set this to WIP because commits are still being added. Let us know when it's ready for review again.

simahawk · 2017-05-15T16:30:38Z

@lasley yes pls :) I'm still cleaning/fixing/adding small improvements and I'll move widgets to models.
Hopefully we can close this during or after the sprint in Barcelona (I will attend remotely).

simahawk · 2017-05-26T08:26:49Z

@lasley I'd say that after this 6f7a594 we can rebase and merge :)
About coverage: I'd like to improve it during the sprint next week but to ease partecipation is better to merge this before so that we already have a "kinda stable" starting point.

simahawk · 2017-05-26T08:27:45Z

BTW I'll re-license already merged modules in a separated PR

simahawk · 2017-05-29T14:32:46Z

@pedrobaeza would you mind hit the button here? I'll improve test cov later, probably tomorrow.
Needs rebase of course...

simahawk force-pushed the add-cms_form-PR branch from cd7eaa2 to 3d73c7b Compare February 16, 2017 14:12

lasley added enhancement needs review labels Feb 16, 2017

lasley added this to the 9.0 milestone Feb 16, 2017

lasley reviewed Feb 17, 2017

View reviewed changes

simahawk mentioned this pull request Feb 24, 2017

[RFC] web_react: React.js Widget OCA/web#562

Closed

tedsalmon approved these changes Mar 2, 2017

View reviewed changes

simahawk force-pushed the add-cms_form-PR branch from 1ebda08 to 26ed9c4 Compare March 2, 2017 13:58

guewen approved these changes Mar 10, 2017

View reviewed changes

simahawk added a commit to simahawk/maintainer-quality-tools that referenced this pull request Mar 10, 2017

Ignore *_example packages in coverage check

a5df148

See OCA/website-cms#9 (review)

simahawk mentioned this pull request Mar 10, 2017

Ignore *_example packages in coverage check OCA/maintainer-quality-tools#435

Merged

simahawk force-pushed the add-cms_form-PR branch from 7dc324b to a84f330 Compare March 10, 2017 14:03

[add] cms_form + cms_form_example

3546f26

simahawk force-pushed the add-cms_form-PR branch from a84f330 to 3546f26 Compare March 10, 2017 14:05

can_edit: check for access rules too

bbf131f

simahawk added 2 commits May 15, 2017 13:48

add subwidgets facilities and help msg by option

f5fd149

improve master slave js

0000512

lasley added work in progress and removed needs review labels May 15, 2017

simahawk added 10 commits May 16, 2017 12:20

improve search form template

270423e

add TODO to improve validation [ci skip]

92eb4f8

[imp] include form name into wrapper css class

274c7d2

fix tests

7325809

[imp] cache form_fields

0b28ebc

[imp] move widgets to models

119ea33

ease widget override

891d7cb

widgets fix/imp

60429a1

better subfields

bda440c

Relicense under LGPL

6f7a594

simahawk added 3 commits May 26, 2017 10:41

update license in README [ci skip]

3bf0c52

[fix] load defaults via defaults_get

48e083d

oops, remove print statement

3c25917

guewen added needs review and removed work in progress labels May 29, 2017

pedrobaeza merged commit 8258504 into OCA:9.0 May 29, 2017

simahawk deleted the add-cms_form-PR branch May 30, 2017 13:04

simahawk added a commit to simahawk/website-cms that referenced this pull request Oct 2, 2017

[ADD] cms_form + cms_form_example (OCA#9)

a29889e

simahawk added a commit to simahawk/website-cms that referenced this pull request Oct 2, 2017

[ADD] cms_form + cms_form_example (OCA#9)

9c06692

simahawk added a commit to simahawk/website-cms that referenced this pull request Oct 2, 2017

[ADD] cms_form + cms_form_example (OCA#9)

3b1730e

simahawk added a commit to simahawk/website-cms that referenced this pull request Oct 18, 2017

[ADD] cms_form + cms_form_example (OCA#9)

439f32b

Uh oh!

[add] cms_form + cms_form_example #9

[add] cms_form + cms_form_example #9

Uh oh!

Conversation

simahawk commented Feb 16, 2017

CMS Form

Features

Uh oh!

coveralls commented Feb 16, 2017

Uh oh!

coveralls commented Feb 16, 2017

Uh oh!

simahawk commented Feb 16, 2017

Uh oh!

lasley commented Feb 17, 2017

Uh oh!

coveralls commented Feb 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lasley Feb 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lasley Feb 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Feb 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lasley commented Feb 28, 2017

Uh oh!

tedsalmon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Mar 2, 2017

Uh oh!

coveralls commented Mar 2, 2017

Uh oh!

coveralls commented Mar 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Mar 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guewen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coveralls commented Mar 10, 2017

Uh oh!

coveralls commented Mar 10, 2017

Uh oh!

coveralls commented Mar 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lasley commented Mar 10, 2017

Uh oh!

coveralls commented Feb 17, 2017 •

edited

Loading

lasley Feb 17, 2017 •

edited

Loading

lasley Feb 17, 2017 •

edited

Loading

coveralls commented Feb 17, 2017 •

edited

Loading

coveralls commented Mar 2, 2017 •

edited

Loading

coveralls commented Mar 6, 2017 •

edited

Loading

coveralls commented Mar 10, 2017 •

edited

Loading

simahawk commented May 29, 2017 •

edited

Loading