[14.0] [MIG] website_field_autocomplete: Migration to 14.0 #870

racielperdomo1993 · 2022-01-12T01:32:30Z

Migration from 10.0 to 14.0

racielperdomo1993 · 2022-01-12T15:03:32Z

already implemented in v11

racielperdomo1993 · 2022-01-12T15:23:57Z

@pedrobaeza I realized that this module is implemented in v11 but it is not merged beacuse an error in the manifest (odoo version 10.0.1.0.0 instead of 11.0.1.0.0) and the pull request is still open since 2017, I migrated it to v14 whithout knowing that because I needed this behavior, is this module still necessary or is there another that has the same behavior? Thanks in advance.

pedrobaeza · 2022-01-12T17:11:05Z

No problem if your commit history contains till them and you have made directly the code adaptation from 10.0 to 14.0

pedrobaeza · 2022-01-12T18:42:19Z

Please don't include merge commits.

racielperdomo1993 · 2022-01-12T18:47:39Z

Please don't include merge commits.
@pedrobaeza Sorry, first time contributing, I saw that the pre-commit hook failed and fixed it, how would be the procedure to add the new commits, squash all commits and don't include merge commits?

pedrobaeza · 2022-01-12T20:47:21Z

Well, that's a question of git, you should rebase instead of pulling or merging.

https://git-scm.com/book/en/v2/Git-Branching-Rebasing

Tardo

Thanks for the work! Can you update the source to use ES6?

Tardo · 2022-05-16T11:46:57Z

website_field_autocomplete/static/src/js/field_autocomplete.js

+         * @param response function Callback for response, accepts array of str
+         */
+        autocomplete: function (request, response) {
+            var self = this;


Can avoid 'self' usage if use arrow functions to preserve the context.

Tardo · 2022-05-16T11:47:59Z

website_field_autocomplete/static/src/js/field_autocomplete.js

+
+    var snippet_animation = require("website.content.snippets.animation");
+
+    snippet_animation.registry.field_autocomplete = snippet_animation.Animation.extend({


Since you are not using effects you can use 'web.public.widget'

Tardo · 2022-05-16T12:02:33Z

website_field_autocomplete/controllers/main.py

+
+
+class Website(Website):
+    @http.route(


Why not use type="json" and POST?

Tardo · 2022-05-16T12:04:43Z

website_field_autocomplete/static/src/js/field_autocomplete.js

+
+        /* Return arguments that are used to initialize autocomplete */
+        autocompleteArgs: function () {
+            var self = this;


Use 'arrow functions' to avoid 'self' usage.

@Tardo I tried to change as little as possible the original code of the module, I modified it with your suggestions please check when you have time, thanks.

miguel-S73 · 2022-10-25T08:19:46Z

@racielperdomo1993 thanks for the work!
I think that would be interesting add compatibility with many2one fields.
You can add this patch to apply this or If you open your repo i can add my patch.
website_field_autocomplete-many2one_compatibility.txt

With these changes I intend that the end user always visualizes the field indicated in data-displayField and uses the value of the data-valueField field internally.

racielperdomo1993 · 2022-10-27T15:11:36Z

@miguel-S73 great, added you as collaborator.

…lete

* Return parsed records from promise * Add `data-value-field` to allow for other value attributes * Fix appearance of demo data (container)

* Break controller getters into two methods to allow for easier inheritance manipulation * Add method in JS to return autocomplete initialization args * Add self.record_ids to represent searched RecordSet * Update request type to JSON in AJAX

* Switch model to website.menu to allow for anonymous access

* Use search_read in controller data getter, instead of custom implementation

* Bump version * Change openerp namespace to odoo * Add OCA icon * Remove jQuery require

Show Input with `displayField` value and generate hide field with `valueField` value

github-actions · 2023-02-26T12:36:58Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

miguel-S73 · 2023-02-27T09:47:48Z

@pedrobaeza @Tardo How do you see this PR?

pedrobaeza · 2023-02-28T07:29:26Z

Sorry, I don't know this module.

github-actions · 2023-07-09T12:36:07Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

racielperdomo1993 closed this Jan 12, 2022

racielperdomo1993 reopened this Jan 12, 2022

pedrobaeza added this to the 14.0 milestone Jan 12, 2022

racielperdomo1993 force-pushed the 14.0-mig-website_field_autocomplete branch from d66e288 to cc1dcd6 Compare January 13, 2022 02:24

Tardo suggested changes May 16, 2022

View reviewed changes

racielperdomo1993 requested a review from Tardo June 12, 2022 14:59

lasley and others added 16 commits October 27, 2022 17:17

[ADD] Create new module website_field_autocomplete

37d2a60

[FIX] Update view attrs to match in website_field_autocomplete

6348d0a

[FIX] Improve JS syntax and data names in website_field_autocomplete

4088b67

[FIX] Return deferred query & update ReadMe in website_field_autocomp…

4b52650

…lete

[IMP] Js modularity and ReadMe in website_field_autocomplete

8a11bf8

[ADD] Demo data on homepage for website_field_autocomplete

caa674f

[IMP] website_field_autocomplete: Switch from JS model to controller

e15f552

[IMP] website_field_autocomplete: Improvements for modularity

3978d5e

* Return parsed records from promise * Add `data-value-field` to allow for other value attributes * Fix appearance of demo data (container)

[FIX] website_field_autocomplete: Move demo to isolated page

ce51cd0

OCA Transbot updated translations from Transifex

2bf75f3

OCA Transbot updated translations from Transifex

0eed2fc

[FIX] website_field_autocomplete: Fix namespacing

55d1a74

[FIX] website_field_autocomplete: Demo data

b80dad7

* Switch model to website.menu to allow for anonymous access

[FIX] website_field_autocomplete: Use search_read

d07af73

* Use search_read in controller data getter, instead of custom implementation

OCA Transbot updated translations from Transifex

c8a9da1

oca-transbot and others added 11 commits October 27, 2022 17:17

OCA Transbot updated translations from Transifex

134759b

[FIX] remove en.po that was erroneously created by transbot

beb6a49

OCA Transbot updated translations from Transifex

ecff0e1

OCA Transbot updated translations from Transifex

d010ff5

[MIG] Make modules uninstallable

f05f931

[MIG] Rename manifest files

7819b1a

[MIG] website_field_autocomplete: Upgrade to v10

175a344

* Bump version * Change openerp namespace to odoo * Add OCA icon * Remove jQuery require

OCA Transbot updated translations from Transifex

28740dc

[UPD] Update website_field_autocomplete.pot

a37eaca

[IMP] website_field_autocomplete: black, isort, prettier

ca02678

[MIG] website_field_autocomplete: Migration to 14.0

4d7e122

miguel-S73 force-pushed the 14.0-mig-website_field_autocomplete branch from ff1664f to 9d76720 Compare October 27, 2022 15:25

[IMP] website_field_autocomplete: compatibility many2one fields

fa3d023

Show Input with `displayField` value and generate hide field with `valueField` value

miguel-S73 force-pushed the 14.0-mig-website_field_autocomplete branch from 9d76720 to fa3d023 Compare October 27, 2022 15:28

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 26, 2023

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 5, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 9, 2023

github-actions bot closed this Aug 13, 2023

Reyes4711-S73 mentioned this pull request Jan 23, 2025

[14.0] [MIG] website_field_autocomplete: Migration to 14.0 #1087

Open

Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025

[14.0][ADD] oca_dependencies: OCA/website#870

1243e16


		var snippet_animation = require("website.content.snippets.animation");

		snippet_animation.registry.field_autocomplete = snippet_animation.Animation.extend({

Uh oh!

[14.0] [MIG] website_field_autocomplete: Migration to 14.0 #870

[14.0] [MIG] website_field_autocomplete: Migration to 14.0 #870

Uh oh!

Conversation

racielperdomo1993 commented Jan 12, 2022

Uh oh!

racielperdomo1993 commented Jan 12, 2022

Uh oh!

racielperdomo1993 commented Jan 12, 2022

Uh oh!

pedrobaeza commented Jan 12, 2022

Uh oh!

pedrobaeza commented Jan 12, 2022

Uh oh!

racielperdomo1993 commented Jan 12, 2022

Uh oh!

pedrobaeza commented Jan 12, 2022

Uh oh!

Tardo left a comment

Choose a reason for hiding this comment

Uh oh!

Tardo May 16, 2022

Choose a reason for hiding this comment

Uh oh!

Tardo May 16, 2022

Choose a reason for hiding this comment

Uh oh!

Tardo May 16, 2022

Choose a reason for hiding this comment

Uh oh!

Tardo May 16, 2022

Choose a reason for hiding this comment

Uh oh!

racielperdomo1993 Jun 10, 2022

Choose a reason for hiding this comment

Uh oh!

miguel-S73 commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

racielperdomo1993 commented Oct 27, 2022

Uh oh!

github-actions bot commented Feb 26, 2023

Uh oh!

miguel-S73 commented Feb 27, 2023

Uh oh!

pedrobaeza commented Feb 28, 2023

Uh oh!

github-actions bot commented Jul 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

miguel-S73 commented Oct 25, 2022 •

edited

Loading