Closed
Conversation
Contributor
Author
|
The changes in this PR are already included in #1191. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the RabbitMQ version to 3.12 to allow usage of poison message handling. Quorum queues allow to set the
delivery-limitpolicy for queues. I.e., how many times a message could fail before being dropped.Currently, the processing worker drops the messages after they fail once (unlike what we would like to have - 3 times). The older versions of RabbitMQ supported the
redeliveredfeature for checking whether a message was redelivered or not, however, there was no way to know how many times it was redelivered.TODO: I am still experimenting and will extend the processing worker implementation to achieve a redelivery count of 3 or ideally any number configured with an env variable, say, 'OCRD_NETWORK_WORKER_QUEUE_MESSAGE_RETRIES'.