Skip to content

Refactor "ocrd process" to be interoperable with OCR-D/spec#171#566

Closed
kba wants to merge 8 commits intomasterfrom
ocrdwf
Closed

Refactor "ocrd process" to be interoperable with OCR-D/spec#171#566
kba wants to merge 8 commits intomasterfrom
ocrdwf

Conversation

@kba
Copy link
Copy Markdown
Member

@kba kba commented Aug 15, 2020

  • ValidationReport -> ocrd_models
  • Decouple parsing and validation of tasks into OcrdWf (workflow), OcrdWfStep and OcrdWfValidator

@kba kba changed the title Ocrdwf Refactor "ocrd process" to be interoperable with OCR-D/spec#171 Aug 15, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 15, 2020

Codecov Report

Merging #566 into master will increase coverage by 0.32%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   84.15%   84.48%   +0.32%     
==========================================
  Files          48       51       +3     
  Lines        2752     2868     +116     
  Branches      538      559      +21     
==========================================
+ Hits         2316     2423     +107     
- Misses        339      347       +8     
- Partials       97       98       +1     
Impacted Files Coverage Δ
ocrd_models/ocrd_models/report.py 100.00% <ø> (ø)
ocrd_models/ocrd_models/ocrd_wf.py 50.00% <50.00%> (ø)
...rd_validators/ocrd_validators/ocrd_wf_validator.py 94.23% <94.23%> (ø)
ocrd/ocrd/cli/validate.py 100.00% <100.00%> (ø)
ocrd_models/ocrd_models/__init__.py 100.00% <100.00%> (ø)
ocrd_models/ocrd_models/constants.py 100.00% <100.00%> (ø)
ocrd_models/ocrd_models/ocrd_wf_step.py 100.00% <100.00%> (ø)
ocrd_validators/ocrd_validators/__init__.py 100.00% <100.00%> (ø)
ocrd_validators/ocrd_validators/json_validator.py 100.00% <100.00%> (ø)
...d_validators/ocrd_validators/ocrd_zip_validator.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3ffe4...bf8d1b1. Read the comment docs.

@kba kba mentioned this pull request Aug 22, 2020
@kba
Copy link
Copy Markdown
Member Author

kba commented Nov 30, 2022

This is now very obsolete, we decided to use nextflow for productive workflows. ocrd process as it-is is enough for simple workflows, so it is beyond time to close this.

@kba kba closed this Nov 30, 2022
@kba kba deleted the ocrdwf branch November 30, 2022 15:58
@bertsky
Copy link
Copy Markdown
Collaborator

bertsky commented Nov 30, 2022

Agreed. Can we get something similar in core based on OtoN, though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants