logging: set non-root logger to NOTSET also when loading from config file#631
Merged
logging: set non-root logger to NOTSET also when loading from config file#631
Conversation
bertsky
approved these changes
Oct 20, 2020
Collaborator
bertsky
left a comment
bertsky
left a comment
There was a problem hiding this comment.
Understood! Better document this though.
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
+ Coverage 84.89% 84.91% +0.02%
==========================================
Files 52 52
Lines 2952 2957 +5
Branches 575 577 +2
==========================================
+ Hits 2506 2511 +5
Misses 332 332
Partials 114 114
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bertsky This was why I originally had
setOverrideLoglevelas part ofintiLoggingin #599: When loading from config file and setting the root logger to the override loglevel, all existing loggers must be set toNOTSET.