Skip to content

Update 2025 04 17#462

Merged
kba merged 29 commits intomasterfrom
update-2025-04-17
Apr 17, 2025
Merged

Update 2025 04 17#462
kba merged 29 commits intomasterfrom
update-2025-04-17

Conversation

@kba
Copy link
Copy Markdown
Member

@kba kba commented Apr 16, 2025

Includes #461 but separate PR because otherwise release.sh changelog would not produce the output we want.

@kba kba requested a review from bertsky April 16, 2025 17:47
Copy link
Copy Markdown
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – thx!

@mikegerber
Copy link
Copy Markdown
Contributor

This contains the - as of yet undiscussed - changes to CER calculation in dinglehopper. Please don't include that in this release. it changes the results for users...

@mikegerber
Copy link
Copy Markdown
Contributor

This contains the - as of yet undiscussed - changes to CER calculation in dinglehopper. Please don't include that in this release. it changes the results for users...

I've released dinglehopper v0.10.0 with the V3 update (but not the proposed change to using normalized CER. (For the latter there is a separate PR now.)

@kba
Copy link
Copy Markdown
Member Author

kba commented Apr 17, 2025

This contains the - as of yet undiscussed - changes to CER calculation in dinglehopper. Please don't include that in this release. it changes the results for users...

I've released dinglehopper v0.10.0 with the V3 update (but not the proposed change to using normalized CER. (For the latter there is a separate PR now.)

You did, thank you, but you also changed minimum python version which broke the release. And I do need to finish this today because I still need to update our local deployment and start processing over the long weekend with the updated processors. We can switch back to upstream dinglehopper once the discussions are finished after Easter but for now, I really need to finish this, I know the fork works and will keep that version for now.

@kba kba merged commit 91649fa into master Apr 17, 2025
1 check passed
@mikegerber
Copy link
Copy Markdown
Contributor

This contains the - as of yet undiscussed - changes to CER calculation in dinglehopper. Please don't include that in this release. it changes the results for users...

I've released dinglehopper v0.10.0 with the V3 update (but not the proposed change to using normalized CER. (For the latter there is a separate PR now.)

You did, thank you, but you also changed minimum python version which broke the release. And I do need to finish this today because I still need to update our local deployment and start processing over the long weekend with the updated processors. We can switch back to upstream dinglehopper once the discussions are finished after Easter but for now, I really need to finish this, I know the fork works and will keep that version for now.

0.10.1 now adds support back for Python 3.8.

So the latest ocrd_all now contains a dinglehopper that produces different CER results compared to the upstream dinglehopper? :-( I do not understand why this change did not go through a proper process, e.g. PRs/issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants