Conversation
bertsky
reviewed
Apr 10, 2025
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
bertsky
approved these changes
Apr 10, 2025
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
bertsky
reviewed
Apr 11, 2025
| COPY README.md . | ||
| COPY Makefile . | ||
| COPY . . | ||
| COPY src/ocrd_froc/ocrd-tool.json . |
Contributor
There was a problem hiding this comment.
just…
Suggested change
| COPY src/ocrd_froc/ocrd-tool.json . | |
| COPY ocrd-tool.json . |
…would suffice (Docker follows and dereferences the symlink)
Member
Author
There was a problem hiding this comment.
Sry saw this too late. Yeah it should, but since I had to test with podman and it did differ in the build call, I wanted to be sure there are no surprises in build behavior.
kba
added a commit
to OCR-D/ocrd_all
that referenced
this pull request
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are still missing, hence draft.Ready.