Skip to content

QA Spec - Schema#236

Closed
kba wants to merge 15 commits intomasterfrom
qa-spec-schema
Closed

QA Spec - Schema#236
kba wants to merge 15 commits intomasterfrom
qa-spec-schema

Conversation

@kba
Copy link
Copy Markdown
Member

@kba kba commented Dec 19, 2022

Just the (still evolving) schema, so #225 can focus on the spec itself.

kba added a commit that referenced this pull request Dec 19, 2022
@kba kba mentioned this pull request Dec 19, 2022
Comment thread ocrd_eval.sample.json Outdated
@mweidling
Copy link
Copy Markdown
Contributor

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.

@kba What do you think?

Comment thread ocrd_eval.schema.json Outdated
Comment thread ocrd_eval.schema.yml Outdated
Comment thread ocrd_eval.schema.yml Outdated
Comment thread ocrd_eval.schema.yml Outdated
Comment thread ocrd_eval.schema.yml
Comment thread ocrd_eval.schema.yml Outdated
Comment thread ocrd_eval.schema.yml Outdated
kba and others added 3 commits January 27, 2023 14:12
Co-authored-by: mweidling <13831557+mweidling@users.noreply.github.com>
Co-authored-by: mweidling <13831557+mweidling@users.noreply.github.com>
Co-authored-by: mweidling <13831557+mweidling@users.noreply.github.com>
@kba
Copy link
Copy Markdown
Member Author

kba commented Jan 27, 2023

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.

@kba What do you think?

That was an oversight that it's not in the schema. Why is it tricky to calculate or rather, how would you calculate pages_per_minute without it?

Comment thread ocrd_eval.schema.yml Outdated
Comment thread ocrd_eval.schema.yml Outdated
Comment thread ocrd_eval.schema.yml
Comment thread ocrd_eval.sample.json Outdated
Comment thread ocrd_eval.schema.json Outdated
Comment thread ocrd_eval.schema.json Outdated
Comment thread ocrd_eval.schema.yml Outdated
Comment thread ocrd_eval.schema.yml Outdated
@mweidling
Copy link
Copy Markdown
Contributor

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.
@kba What do you think?

That was an oversight that it's not in the schema. Why is it tricky to calculate or rather, how would you calculate pages_per_minute without it?

My first naive approach would be to look at the processing time for the complete work, calculate the mean processing time for a page and use this as basis for obtaining pages_per_minute. The arithmetic mean for a page cannot be used for processing_time, though, as this would imply the actual time this page took.

kba and others added 4 commits March 14, 2023 16:02
Co-authored-by: mweidling <13831557+mweidling@users.noreply.github.com>
Co-authored-by: mweidling <13831557+mweidling@users.noreply.github.com>
@kba kba marked this pull request as ready for review March 14, 2023 15:38
@kba
Copy link
Copy Markdown
Member Author

kba commented Mar 14, 2023

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.
@kba What do you think?

That was an oversight that it's not in the schema. Why is it tricky to calculate or rather, how would you calculate pages_per_minute without it?

My first naive approach would be to look at the processing time for the complete work, calculate the mean processing time for a page and use this as basis for obtaining pages_per_minute. The arithmetic mean for a page cannot be used for processing_time, though, as this would imply the actual time this page took.

pages_per_minute is likely the more interesting measure, so feel free to focus on that.

@mweidling
Copy link
Copy Markdown
Contributor

processing_time as benchmark for a page is only given in the example files and not defined in the schema YAML. Since it's a bit tricky to calculate it I also wanted to know what the overall value of this is. If it doesn't have that much of a value I recommend to toss it and focus on pages_per_minute instead.
@kba What do you think?

That was an oversight that it's not in the schema. Why is it tricky to calculate or rather, how would you calculate pages_per_minute without it?

My first naive approach would be to look at the processing time for the complete work, calculate the mean processing time for a page and use this as basis for obtaining pages_per_minute. The arithmetic mean for a page cannot be used for processing_time, though, as this would imply the actual time this page took.

pages_per_minute is likely the more interesting measure, so feel free to focus on that.

Let's skip processing_time for pages then for now. I'll make an issue so that we can implement it in a later stage.

Comment thread ocrd_eval.schema.yml
@kba
Copy link
Copy Markdown
Member Author

kba commented Mar 16, 2023

Sry, I accidentally rebased instead of merging, but it is all in master now.

@kba kba closed this Mar 16, 2023
@mweidling
Copy link
Copy Markdown
Contributor

Sry, I accidentally rebased instead of merging, but it is all in master now.

Alright, thank you!

@mweidling
Copy link
Copy Markdown
Contributor

I'll remove the branch then.

@kba kba deleted the qa-spec-schema branch March 21, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants