Allow setting env variables when running binaries on linux #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
commented
Dec 11, 2025
NathanReb
force-pushed
the
makeself-env
branch
from
499907c to
7d26486
Compare
ddeclerck
approved these changes
Dec 11, 2025
Contributor
ddeclerck
left a comment
ddeclerck
left a comment
There was a problem hiding this comment.
LGTM - we're just waiting for the missing macOS part.
Collaborator
Author
|
CI's broken and can't even install OCaml :/ |
Contributor
Seems there were some timeouts on GitHub. Might be working now. However there's also an actual error somewhere : you're using |
Signed-off-by: Nathan Rebours <nathan.rebours@ocamlpro.com>
NathanReb
force-pushed
the
makeself-env
branch
from
7d26486 to
ed502b3
Compare
Collaborator
Author
|
I fixed the |
Signed-off-by: Nathan Rebours <nathan.rebours@ocamlpro.com>
NathanReb
force-pushed
the
makeself-env
branch
from
ed502b3 to
a4b1260
Compare
Collaborator
Author
|
Ended up adding the support for |
ddeclerck
reviewed
Dec 18, 2025
| target system. You can refer to the application's install directory absolute | ||
| path using the `<install_path>` variable. | ||
| *Example:* | ||
| `[["VAR1", "value1"], ["VAR2", "<install_path>/lib"]]`. |
Contributor
There was a problem hiding this comment.
Just realizing, under WiX, where <install_path> resovles to [APPLICATIONFOLDER], there is always a terminating \. Hope it will not cause problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88