Skip to content

Conversation

@emilienlemaire
Copy link

This PR should enable coverage to work with our superbol-studio extension

@emilienlemaire emilienlemaire requested a review from nberth May 2, 2024 14:10
Copy link

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would pushing those changes upstream make sense? In this case the "style" fixes could stay. Otherwise, I'm afraid changes need to be kept to a minimum to facilitate future merges.

@emilienlemaire
Copy link
Author

It turn out my linter autorunned on save, and I did not check all the changes before committing, I'll revert to only the logical changes in a few

@emilienlemaire emilienlemaire requested a review from nberth May 3, 2024 08:55
Copy link

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please squash before merge.
Oh, and edit the title for a proper description (like "Auto-update displayed coverage")?

@emilienlemaire emilienlemaire changed the title Enable coverage Auto-update coverage highlighting May 3, 2024
@emilienlemaire emilienlemaire merged commit 3e61d84 into OCamlPro:superbol-vscode-debug May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants