Sfresults #123
Sfresults #123
Conversation
sreeder
requested review from
Elijahwalkerwest,
emiliom,
horsburgh and
lsetiawan
odm2api/ODM2/services/readService.py
Outdated
| return None | ||
|
|
||
| # Results | ||
| def getResults(self, ids=None, type=None, uuids=None, actionid=None, simulationid=None, sfid=None, |
There was a problem hiding this comment.
While we are at this, can type change to restype?
There was a problem hiding this comment.
Also, is sfid being used anymore? If not, can it be removed?
There was a problem hiding this comment.
@lsetiawan I don't want to just delete the parameters because I know there are people out there who are using these functions, and just removing them would cause their code to stop working. So what I am doing is adding a warning message to let them know the function call will be changing, so that people have a little time to make the change. then the next release we do, we can delete them. but yes I can add restype. and a warning message to type,
There was a problem hiding this comment.
Ah okay. Thanks for the explanation. That makes sense 😄
| Version VARCHAR (255) NULL, | ||
| ModelLink VARCHAR (255) NULL | ||
| """ | ||
| def test_getSamplingFeatureByCode(self): |
|
I have a few questions before I think it's ready. Also, there are conflicts that need to be addressed. Thanks @sreeder. |
address /samplingfeatureresults endpoint in the REST API by adding parameters to the getResults function. deprecate sfid parameter in lieu of sfids to allow the user to send in multiple ids at a time.