Error in DataLoggerFiles and DataLoggerFileColumns #132 #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelcleon
approved these changes
Dec 20, 2017
Member
Author
|
Travis CI are now passing. I have approval by @miguelcleon. So I think it is safe to merge. |
Member
Author
|
Merging... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the same exact changes by @miguelcleon on PR #133. Just cleaner without the
.travis.ymlchanges.Notes
From @miguelcleon:
see that the first one, this is caused by Dataloggerfiles model, mapping to the wrong column within the database: https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L458.
For the second one, measurementequation is indeed misspelled: https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L514.
also
found two more problems with dataloggerfiles model
There is no column
dataloggeroutputfiledescriptioninstead it isdataloggerfiledescriptionhttps://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L460
There is no column
dataloggeroutputfilelinkinstead it isdataloggerfilelinkhttps://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L461