Skip to content

Conversation

@lsetiawan
Copy link
Member

Overview

Update README to reflect changes to conda-forge channel and how to install the latest development version.

@lsetiawan lsetiawan requested a review from emiliom February 26, 2018 21:12

3. Install the latest commit from the development branch
```bash
pip install git+https://github.com/ODM2/ODM2PythonAPI.git@development#egg=odm2api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the #egg=odm2api part do? I'm not familiar with that syntax. I've previously pip installed from a github branch using just this:

pip install git+https://github.com/ODM2/ODM2PythonAPI.git@development

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#egg is just a way to explicitly state project name. Not really needed when you do just a pip install, but does needed if doing pip install -e. See reference.

2. Create conda environment from the two text files.
```bash
conda create -n odm2api_dev -c conda-forge python=2.7 --file requirements.txt --file requirements-dev.txt
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add statement to activate the new conda env, before the next instructions (pip install). As usual, this will have to list the instructions for Linux/MacOSX vs Windows.

README.md Outdated
wget https://raw.githubusercontent.com/ODM2/ODM2PythonAPI/master/requirements-dev.txt
```

2. Create conda environment from the two text files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing to this:

  1. Create conda environment odm2api_dev from the two requirements* text files.

@emiliom
Copy link
Member

emiliom commented Feb 27, 2018

@lsetiawan I made a couple of suggestions for edits. If you agree with them, go ahead and implement them, then merge this PR yourself. Everything else looked good. Thanks!

Copy link
Member

@emiliom emiliom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comments

@emiliom
Copy link
Member

emiliom commented Feb 27, 2018

Also, why don't you go ahead and also address in this PR this comment I made last week:

in the odm2api docs, the dev installation information at http://odm2.github.io/ODM2PythonAPI/installing.html#installing-the-development-version is missing the statement to use to install odm2api from the local clone. This would be the very last line in that doc page, I think.

To which you replied:

Yea that would be good to add that in. Typically user would cd into the directory, git checkout to the development branch, then pip install -e .

@lsetiawan lsetiawan merged commit 88bc642 into ODM2:development Feb 27, 2018
@lsetiawan lsetiawan deleted the update_readme branch February 27, 2018 18:04
@lsetiawan lsetiawan mentioned this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants