Addinheritance #39
Merged
Addinheritance #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 23, 2016 10:29
…t functions with inheritance
This was referenced Apr 4, 2016
Contributor
Author
|
If there is no feedback I will merge the branch on April 7th. |
SamplingFeatures.FeatureGeometry won't be used by default; FeatureGeometryWKT will be used instead. So, the __repr__ method should return FeatureGeometryWKT, not FeatureGeometry
| SamplingFeatureObj = relationship(SamplingFeatures) | ||
| # SamplingFeatureObj = relationship(SamplingFeatures) | ||
| __mapper_args__ = { | ||
| 'polymorphic_identity':'Specimen', |
Member
There was a problem hiding this comment.
Should it be 'polymorphic_identity':'specimens', (lowercase and plural)? I don't know myself, but that seems more consistent with what you're doing in Results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added inheritance, for results and sampling features, and I have tested it for both creation and reading. I was also able to add an init function to the base inherited class