Skip to content

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Sep 28, 2017

Here is a demo that I force pushed earlier today:

http://odm2.github.io/ODM2PythonAPI/

There are still a few things to adjust and I am having trouble with latest doctr. Looking into it...

Copy link
Member Author

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I moved all the files from the doc page to docs/NOTES to avoid conflicting with the "new" docs.

We should migrate those to the new docs later.

@@ -1,3 +1,5 @@
# use http://lint.travis-ci.org/ to check the file.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder on how to check the file.


env:
global:
- secure:` "yxu/J/VNed5R6Fs1D5YJZ9hN3bMFAOBxFOkVyoxSfzTsDWeJ0rNLMljn7TTFeBBFpNI6PG3RFIzeOd3AAbtZKr4dQ/aL70woQ2nF7lNDbofudE+bdc/K0fKhS4dZZeMKyeRI3LItQgGJ1vSOYDGfpq0EhOd17d1oo9pqjDli+pTzjJ6qvDQ41e5mmRPVXIqJ2mLpnf+jZdvHJTzog0d4kS+BQOqhLYe1AATyYyHFrs95kroAVkLbuPhQ0KVQX3h8NV3OD+x+qQjmM2Zl6mygoABh8jbkAv2/Kx/WcBR/rLO6WG2z+ZBwdP/2R7/Gh0Tac9An+Kvf8L1GCdyeMoS55XlUTwyqbpOQydASs8PlGnQuNFk3QaeJcjWJgFJjoYUDC8yQt/avkjkiPPa6kraUQalEYD66t5dKrL2UICCUUJ4lXkHGD532tLOFS2dJTRRgUQD/d8q4cNzdNY9X4LaHYDJxhFWi+sV/gOYrSSc1uF4pxlpU8naBR/eaJHN1+eGb5h76LC1uF7zcjYLFmsP+YmMVwyVKU3bbcPmHNsoDgrtAY0bF4gDVLDeqmZzt4OLz9ATtHNRST9yEjmiyjUXX9O+kXYFGOd14XMw+S0vdqwSPeobavFTaUmz0+AUQiPkJf0FpLbHmUHfY/0m3PvlwQYFyskgYzjjhNtR362fCtgg="
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows for doctr to push to gh-pages.

- export PATH="$HOME/miniconda/bin:$PATH"
- conda config --set always_yes yes --set changeps1 no --set show_channel_urls true
- conda update conda
- conda config --add channels conda-forge --force
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this to install doctr and other modules.
Ideally we should migrate the odm2 channel to conda-forge to avoid the need for 3 channels.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should migrate the odm2 channel to conda-forge to avoid the need for 3 channels.

Thanks for the reminder. Let's discuss it in the near future, say, starting next week (not this week)

make clean html linkcheck ;
popd ;
python -m doctr deploy --sync .;
python -m doctr deploy --sync --no-require-master --built-docs docs/build/html "docs-$TRAVIS_BRANCH" ;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this section we:

  • install doctr.
  • build the docs from scratch and check the links.
  • push to both the / and the docs-version directory so we can have latest and versioned docs;

@@ -0,0 +1,20 @@
# Minimal makefile for Sphinx documentation
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boilerplate generated with sphinx-quickstart.

@@ -0,0 +1,177 @@
# -*- coding: utf-8 -*-
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is mostly boilerplate from sphinx-quickstart but I made a few tweaks to customize the docs page.

@@ -0,0 +1,7 @@
:mod:`ODMconnection`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only an example. We can add all the modules later once this is working.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

flake8-print
flake8-quotes
mock
nbsphinx
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this extension we can convert Jupyter notebooks examples to docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I like the example from the folium docs

@ocefpaf ocefpaf requested a review from lsetiawan September 28, 2017 17:34
@emiliom
Copy link
Member

emiliom commented Sep 28, 2017

Note that I moved all the files from the doc page to docs/NOTES to avoid conflicting with the "new" docs.

We should migrate those to the new docs later.

I'm fine with what you did. All those documents are old, most of them are 2 years old. And at least a couple of them are actually old, manual attempts (by Stephanie?) at documenting the API. So, they'll be replaced by or integrated into the Sphinx system we're building.

@emiliom emiliom merged commit 627d749 into ODM2:master Sep 28, 2017
@ocefpaf ocefpaf deleted the docs branch September 28, 2017 17:59
@lsetiawan lsetiawan mentioned this pull request Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants