ddl postgres issues

[mattlevine22]

I'm trying to set up the cdm in postgres, and have run into a few issues, some of which others have mentioned. I'll consolidate them here--let me know if they should be broken out into separate issues.

1. ddl on Postgres #96 There is an issue with the naming of "offset" in the note_nlp table in the DDL postgres file.
2. ddl postgres visit_occurrence.discharge_to_concept_id bug #97 There is a bug in the declaration of "discharge_to_concept_id" in the visit_occurrence table in the DDL postgres file. It is defined as "INTEGER(50)", and should probably just be INTEGER.
3. In constraints postgres file, there is a syntax error in line 129 caused by the word "NONCLUSTERED". I assume the appropriate fix is to just remove that word.
4. In indexes required postgres file, there is a reference to "person_id" in the note_nlp table, but person_id is not defined in the note_nlp table by the ddl file. Perhaps person_id needs to be added to that table in the ddl file.
5. In constraints postgres file, the foreign key "dose_unit_concept_id" does not exist in the DDL postgres file. (the closest thing i could find in the ddl file is "dose_unit_source_value", which, coincidentally, is not referenced in the constraints file).

[clairblacketer]

@mattlevine22 thank you so much for highlighting these. Some of these issues could also be issues with the other ddls so I will take a look at all of them to be safe.

[bobml]

I would have to concur with mattlevine22 also, I encountered all of these issues as well.

[vojtechhuser]

I made PR that fixes the integer(50) problem 3 days prior this report.