Obs period datetime patch #64
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me. |
mark-velez
added a commit
to mark-velez/curation
that referenced
this pull request
Jul 1, 2017
* As defined by OMOP spec (see https://github.com/OHDSI/CommonDataModel) * Datetimes in observation_period will likely be removed (see OHDSI/CommonDataModel#64)
Contributor
|
Guys: We need to put this through the WG on the 11th. Can't just pull things out. |
Contributor
|
yes we can because it was never in the proposal to begin with. it was an
error we can fixing.
…On Jul 2, 2017 7:57 AM, "Christian Reich" ***@***.***> wrote:
Guys: We need to put this through the WG on the 11th. Can't just pull
things out.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAsrGomwYzrueOTZHk6I-6hXH5zgKNuDks5sJ4WygaJpZM4OA_Yw>
.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes datetime fields from OBSERVATION_PERIOD table DDL in sql server, postgres and oracle. Impala did not have this issue.