[Server] Fix Sampling Group creating a new long running task for every Client AddMonitoredItems Method Call#2984
Merged
mrsuciu merged 3 commits intoOPCFoundation:masterfrom Feb 11, 2025
Conversation
…Add MonitoredItems Method Call
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2984 +/- ##
==========================================
- Coverage 55.50% 55.43% -0.08%
==========================================
Files 352 352
Lines 67851 67854 +3
Branches 13904 13904
==========================================
- Hits 37664 37618 -46
- Misses 26072 26114 +42
- Partials 4115 4122 +7 ☔ View full report in Codecov by Sentry. |
mrsuciu
reviewed
Feb 7, 2025
mrsuciu
approved these changes
Feb 7, 2025
mregen
pushed a commit
to mregen/UA-.NetStandard
that referenced
this pull request
Feb 12, 2025
…y Client AddMonitoredItems Method Call (OPCFoundation#2984) * fix Sampling Group creating a new long running task for every Client Add MonitoredItems Method Call * reset also on shutdown * dispose shutdown event
mregen
pushed a commit
that referenced
this pull request
Feb 13, 2025
…y Client AddMonitoredItems Method Call (#2984) * fix Sampling Group creating a new long running task for every Client Add MonitoredItems Method Call * reset also on shutdown * dispose shutdown event
13 tasks
mregen
added a commit
that referenced
this pull request
Feb 13, 2025
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix the SamplingGroup of the Server to only initiate startup of the sampling task if it does not exist yet. As in the previous implementation a new sampling task was started on every Client AddMonitoredItems Service Call for a node being handled by the core Node Manager.
Related Issues
Types of changes
Checklist
Further comments