Skip to content

[Server] Fix Sampling Group creating a new long running task for every Client AddMonitoredItems Method Call#2984

Merged
mrsuciu merged 3 commits intoOPCFoundation:masterfrom
romanett:fixSamplingGroup
Feb 11, 2025
Merged

[Server] Fix Sampling Group creating a new long running task for every Client AddMonitoredItems Method Call#2984
mrsuciu merged 3 commits intoOPCFoundation:masterfrom
romanett:fixSamplingGroup

Conversation

@romanett
Copy link
Copy Markdown
Contributor

@romanett romanett commented Feb 6, 2025

Proposed changes

Fix the SamplingGroup of the Server to only initiate startup of the sampling task if it does not exist yet. As in the previous implementation a new sampling task was started on every Client AddMonitoredItems Service Call for a node being handled by the core Node Manager.

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@romanett romanett added the bug A bug was identified and should be fixed. label Feb 6, 2025
@romanett romanett added this to the 1.5.376 Final 1.05.04 Updates milestone Feb 6, 2025
@romanett romanett requested a review from mrsuciu February 6, 2025 06:05
@romanett romanett self-assigned this Feb 6, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.43%. Comparing base (cf82847) to head (6bcdb3e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...braries/Opc.Ua.Server/NodeManager/SamplingGroup.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2984      +/-   ##
==========================================
- Coverage   55.50%   55.43%   -0.08%     
==========================================
  Files         352      352              
  Lines       67851    67854       +3     
  Branches    13904    13904              
==========================================
- Hits        37664    37618      -46     
- Misses      26072    26114      +42     
- Partials     4115     4122       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrsuciu mrsuciu merged commit 1baf420 into OPCFoundation:master Feb 11, 2025
@romanett romanett deleted the fixSamplingGroup branch February 11, 2025 14:20
mregen pushed a commit to mregen/UA-.NetStandard that referenced this pull request Feb 12, 2025
…y Client AddMonitoredItems Method Call (OPCFoundation#2984)

* fix Sampling Group creating a new long running task for every Client Add MonitoredItems Method Call

* reset also on shutdown

* dispose shutdown event
mregen pushed a commit that referenced this pull request Feb 13, 2025
…y Client AddMonitoredItems Method Call (#2984)

* fix Sampling Group creating a new long running task for every Client Add MonitoredItems Method Call

* reset also on shutdown

* dispose shutdown event
mregen added a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A bug was identified and should be fixed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opc.Ua.Server SamplingGroup is spawning too many threads.

2 participants