Skip to content

[Server] Fix Subscription Diagnostics DataChangeNotificationsCount being calcualted incorrectly#3119

Merged
mrsuciu merged 1 commit intoOPCFoundation:rollback-removeNet6from
romanett:feat/fixSubscriptionDiagnostics
Jul 17, 2025
Merged

[Server] Fix Subscription Diagnostics DataChangeNotificationsCount being calcualted incorrectly#3119
mrsuciu merged 1 commit intoOPCFoundation:rollback-removeNet6from
romanett:feat/fixSubscriptionDiagnostics

Conversation

@romanett
Copy link
Copy Markdown
Contributor

Proposed changes

Fix Subscription Diagnostics DataChangeNotificationsCount being calcualted incorrectly for small MaxNotificationPerPublish Values.

thanks to @nilvs-abb for reporting this.

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@mrsuciu mrsuciu merged commit 7af96c1 into OPCFoundation:rollback-removeNet6 Jul 17, 2025
38 of 79 checks passed
@romanett romanett deleted the feat/fixSubscriptionDiagnostics branch August 4, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants