Conversation
… the hyrax-docker build recippes
This reverts commit fa5829a.
ndp-opendap
requested review from
hannahilea and
jgallagher59701
and removed request for
jgallagher59701
hannahilea
left a comment
hannahilea
left a comment
There was a problem hiding this comment.
See comments:
- there's one change that has to happen before this PR merges or it will fail on master when running trigger-hyrax-docker.sh
- consider adding the tagging behavior to hyrax-docker before merging this PR
Approving b/c I think those are trivial changes and not worth blocking over!
| "; | ||
| git status; | ||
|
|
||
| export hyrax_tag="hyrax-${HYRAX_BUILD_VERSION}" |
There was a problem hiding this comment.
Hrm, interesting. Is hyrax-docker now responsible for tagging itself upon building? I don't remember that being updated in the previous hyrax-docker PR (although maybe it was) so it's probably worth making that change before we merge this PR, or we'll end up with a few untagged builds (in hyrax-docker)?
There was a problem hiding this comment.
Now that I have made and merged the changes to hyrax-docker that handle this tagging I'll drop it from the build recipes created by the OLFS
There was a problem hiding this comment.
I think the tagging in hyrax-docker was specifically the docker hub tagging. In this PR, we're removing the github tagging. So I think we still need to add github tagging at the hyrax-docker level (i.e., copy the lines removed here and move them over there)?
There was a problem hiding this comment.
I think that's right we basically want to tag the hyrax-docker project with the current Hyrax version tag.
hmmmm - ticket time.
There was a problem hiding this comment.
Here is the issue: OPENDAP/hyrax-docker#136
Here is the PR: OPENDAP/hyrax-docker#137
|
2 participants
This PR changes the OLFS so that it no longer injects Hyrax version information into the code base. The result is that the Hyrax version is set to
Not.A.Releaseand the hyrax-docker CICD will determine the version and build numbers and inject them into the server when it runs.This should be merged AFTER OPENDAP/hyrax-docker#126 is merged.