Open
Conversation
Contributor
Author
|
This branch will need a test deployment on SIT to verify that I did not go too far... |
|
jgallagher59701
approved these changes
Mar 12, 2026
Member
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
See my notes about the commented out code
| providedCompile group: 'javax.servlet', name: 'javax.servlet-api', version: '3.0.1' | ||
| providedCompile group: 'javax.servlet', name: 'javax.servlet-api', version: '3.1.0' | ||
| providedCompile group: 'javax.xml.bind', name: 'jaxb-api', version: '2.3.0' | ||
| // providedCompile group: 'javax.xml.bind', name: 'jaxb-api', version: '2.3.0' |
Member
There was a problem hiding this comment.
I suggest that you put a copy of build.gradle with a suffix like '.with_old_libs.3.11.26' and remove the commented stuff. Sonar gripes at me about commented out code and I used to balk, but it's turned out to be for the better.
Contributor
Author
There was a problem hiding this comment.
I was planning to just trust Git and remove it all after we got a successful test-deploy test in SIT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes WCS related cruft and associated libs from the
opendap.dap4package