Conversation
nkoukpaizan
approved these changes
Apr 25, 2026
Collaborator
nkoukpaizan
left a comment
nkoukpaizan
left a comment
There was a problem hiding this comment.
There is one more WORKING_DIRECTORY in tests/functionality/pflow/CMakeLists.txt that should be safe to cleanup.
Otherwise looks good to me. This cleans up the *.warning files that were showing up in the source directory!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request type
Relates to
This MR updates
Summary
Remove some annoying dead code from CMake files. Tests pass on HIP platform.