Governor Documentation and Model#103
Closed
lukelowry wants to merge 145 commits into
Closed
Conversation
pelesh
requested changes
May 8, 2025
Collaborator
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
Great work! It would be good to make some additional clarification and make sure equations match the signal flow diagram.
Collaborator
Author
|
Comments addressed. Awaiting @abirchfield comments, especially in regards to clarifying units. |
Collaborator
Author
|
Untested implementation in recent commit, aligned with documentation. |
* size_quad() --> sizeQuadrature(). * Add missing overrides in IdaTests. * Fix time assert with tolerance within a namespace. * Use GridKit's isEqual in example2 time stamp assertion. --------- Co-authored-by: nkoukpaizan <nkoukpaizan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documentation for the phasor dynamics governor (TGOV1) that will be implemented following this PR.
Proposed changes
Restructured folder to allow for many gov. types and added documentation for TGOV1
Further comments
There are piece-wise differential equations in this system. I wrote a short proposal on how to implement this to cooperate with the general solver. Please let me know if a bump function is sufficient or if the general solver can handle piece-wise definition (not to my knowledge).
Also there was a small latex issue in GENROU that I included in this PR.
Checklist