Conversation
Collaborator
reid-g
commented
May 8, 2024
reid-g
commented
- Added example of scalable microgrid with arbitrary size
- Added example of scalable microgrid with arbitrary size
Closed
pelesh
approved these changes
May 24, 2024
Collaborator
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
All tests pass, clean example implementation. Minor corrections suggested before the merge.
Co-authored-by: pelesh <peless@ornl.gov>
pelesh
requested changes
May 24, 2024
Collaborator
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
Minor corrections as suggested in this review would make this example cleaner.
- Remove dependence on data files. - Check whether tests pass. - Fix code style.
pelesh
approved these changes
Jun 4, 2024
pelesh
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Added scalable microgrid example with arbitrary size * Example is tested with microgrids with 2, 4 and 8 repeated blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.