Move PowerSystemsData.hpp and CircuitGraph.hpp to correct subdirectories#114
Merged
Move PowerSystemsData.hpp and CircuitGraph.hpp to correct subdirectories#114
PowerSystemsData.hpp and CircuitGraph.hpp to correct subdirectories#114Conversation
pelesh
added
enhancement
Collaborator
Author
nkoukpaizan
approved these changes
May 27, 2025
Collaborator
nkoukpaizan
left a comment
nkoukpaizan
left a comment
There was a problem hiding this comment.
The changes look good to me. Tests pass in CI and on Frontier.
WiktoriaZielinskaORNL
pushed a commit
that referenced
this pull request
Jul 23, 2025
…ctories (#114) * Mowe PowerSystemsData.hpp to src/Models/PowerFlow. * Move CircuitGraph.hpp to Model/PowerElectronics * Move Matpower parser to src/Model/PowerFlow --------- Co-authored-by: pelesh <pelesh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PowerSystemsData.hpp->src/Model/PowerFlow.CircuitGraph.hpp->src/Model/PowerElectronics.FileIO.hppas it is needed only for power flow models.@alexander-novo @abdourahmanbarry @reid-g @abirchfield @lukelowry
Proposed changes
PowerSystemsData.hppis used only by power flow and experimental models. It is specific to Matpower input data and will not be used for phasor domain dynamics models.CircuitGraph.hppis used only for power electronics models.Most of the models do not need to include either of the two header files.
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments