Implement system model data structure and system composer#138
Merged
Implement system model data structure and system composer#138
Conversation
4c5d9c0 to
c651bca
Compare
Collaborator
|
My opinion on this "meta model" architecture: Good things
Not good things
Here I set it up with Buses and Components separate, and then components further divided into categories, and then one folder per bus class or component class. Of course I left out all the cmake and doc files.
|
Closed
Collaborator
Author
This is excellent feedback but it goes way beyond the scope of this PR. I created a separate issue to follow up on this: #140. The purpose of this PR is to provide initial draft for metamodels to enable development of file I/O. |
Collaborator
superwhiskers
left a comment
There was a problem hiding this comment.
this seems fine to me. the only thing i'd suggest is places to write
- variables to monitor
- overridden
va_baseandfreq_basevalues - disambiguation strings for devices (as in the specification)
abirchfield
approved these changes
Jun 13, 2025
WiktoriaZielinskaORNL
pushed a commit
that referenced
this pull request
Jul 23, 2025
* Add bus factory to phasor dynamics family. * Add system model data for phasor dynamics family. * Use SystemModelData to instantiate system in phasor dynamic Example 1. * Add unit test for system constructor. --------- Co-authored-by: pelesh <pelesh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create system composer that assembles and instantiates system model from system data.
@reid-g @alexander-novo @abdourahmanbarry @Steven-Roberts
Proposed changes
This is in preparation for implementing file I/O. Features added:
SystemModelDatastructure that encapsulates containers for different component models data.SystemModelthat takesSystemModelDataas the input, instantiates all the components, and assembles the system based on the connectivity information in the system data.SystemModelDatastores system's meta model. The meta model is used to abstract I/O from the actual code and to allow system preprocessing before instantiating component models.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments