Skip to content

fix the means by which cmake finds the suitesparse include directory#175

Merged
pelesh merged 1 commit intodevelopfrom
fix-find-suitesparse
Jul 8, 2025
Merged

fix the means by which cmake finds the suitesparse include directory#175
pelesh merged 1 commit intodevelopfrom
fix-find-suitesparse

Conversation

@superwhiskers
Copy link
Copy Markdown
Collaborator

this is just a really minor fix so that cmake finds the include directory for suitesparse (on my system, at least)

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

@superwhiskers
Copy link
Copy Markdown
Collaborator Author

the test failure does not appear to be related to the change this pull request is for

@nkoukpaizan
Copy link
Copy Markdown
Collaborator

the test failure does not appear to be related to the change this pull request is for

There's a non-deterministic behavior somewhere. I just re-ran the pipeline and it passed. The wrong answer we got when it failed was kind of scary.

@superwhiskers
Copy link
Copy Markdown
Collaborator Author

i saw it fail in #169 as well. same test if i recall correctly, PhasorDynamicsGenClassicalTest

@pelesh pelesh merged commit 9fb5e85 into develop Jul 8, 2025
7 of 10 checks passed
@pelesh pelesh deleted the fix-find-suitesparse branch July 24, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants