Refactor Tgov1 model: new parameter parsing, safe valve logic#195
Merged
Refactor Tgov1 model: new parameter parsing, safe valve logic#195
Conversation
shakedregev
approved these changes
Jul 23, 2025
Collaborator
shakedregev
left a comment
shakedregev
left a comment
There was a problem hiding this comment.
This looks good. I was not able to build myself because of constantly evolving dependencies, but I witnessed the tests passing on Wiktoria's machine. Note that test 13 is failing unrelatedly.
shakedregev
reviewed
Jul 23, 2025
shakedregev
reviewed
Jul 23, 2025
WiktoriaZielinskaORNL
changed the title
Collaborator
|
I was able to run this successfully. |
superwhiskers
approved these changes
Jul 23, 2025
Collaborator
superwhiskers
left a comment
superwhiskers
left a comment
There was a problem hiding this comment.
i don't see anything wrong with this. once this one comment is addressed, this can be merged.
pelesh
force-pushed
the
wiktoria_zielinska-tgov_refactor
branch
from
caa9f4d to
ac53335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
Tgov1governor model in GridKit to improve code clarity, parameter handling, and testability.Changes include:
Parameter parsing is now cleanly handled through
Tgov1Data, consistent with other models.Closes: #176
Proposed changes
Refactored
Tgov1.cppandTgov1.hppto use parameter maps fromTgov1Data.Checklist
-Wall -Wpedantic -Wconversion -Wextra.