Separate internal and external residuals in PowerElectronics models#376
Merged
Separate internal and external residuals in PowerElectronics models#376
Conversation
7fc7847 to
3a87688
Compare
pelesh
approved these changes
Apr 27, 2026
Collaborator
pelesh
left a comment
There was a problem hiding this comment.
Very well focused PR addressing the issue at hand. Please address minor comments before we merge it.
77f6cc9 to
dd14000
Compare
c4b3e6f to
241cf82
Compare
Collaborator
|
I suggest merging target branch to |
88b1700 to
52c72eb
Compare
Collaborator
Author
|
@pelesh Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #353. Separates the internal and external residual evaluations of all
PowerElectronicsmodels so that the internal residuals of all components can be easily evaluated in parallel.Proposed changes
Two new pure virtual functions have been added to
CircuitComponent:evaluateInternalResidual()andevaluateExternalResidual(). There is now a final implementation forCircuitComponent::evaluateResidual()which just calls these two new functions.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments