Skip to content

Separate internal and external residuals in PowerElectronics models#376

Merged
pelesh merged 7 commits intodevelopfrom
alex/pow-elec-internal-external-residuals
Apr 30, 2026
Merged

Separate internal and external residuals in PowerElectronics models#376
pelesh merged 7 commits intodevelopfrom
alex/pow-elec-internal-external-residuals

Conversation

@alexander-novo
Copy link
Copy Markdown
Collaborator

@alexander-novo alexander-novo commented Apr 13, 2026

Description

Partially addresses #353. Separates the internal and external residual evaluations of all PowerElectronics models so that the internal residuals of all components can be easily evaluated in parallel.

Proposed changes

Two new pure virtual functions have been added to CircuitComponent: evaluateInternalResidual() and evaluateExternalResidual(). There is now a final implementation for CircuitComponent::evaluateResidual() which just calls these two new functions.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

@alexander-novo alexander-novo force-pushed the alex/pow-elec-internal-external-residuals branch from 7fc7847 to 3a87688 Compare April 13, 2026 17:48
Copy link
Copy Markdown
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well focused PR addressing the issue at hand. Please address minor comments before we merge it.

Comment thread GridKit/Model/PowerElectronics/Capacitor/Capacitor.cpp
Comment thread GridKit/Model/PowerElectronics/Capacitor/Capacitor.hpp
Comment thread GridKit/Model/PowerElectronics/LinearTransformer/LinearTransformer.cpp Outdated
Comment thread GridKit/Model/PowerElectronics/MicrogridLine/MicrogridLine.cpp Outdated
@alexander-novo alexander-novo force-pushed the alex/pow-elec-node-objects branch 2 times, most recently from 77f6cc9 to dd14000 Compare April 27, 2026 19:29
@alexander-novo alexander-novo force-pushed the alex/pow-elec-internal-external-residuals branch from c4b3e6f to 241cf82 Compare April 27, 2026 19:47
@pelesh
Copy link
Copy Markdown
Collaborator

pelesh commented Apr 30, 2026

I suggest merging target branch to develop first and then rebasing this to develop and merging it there.

@alexander-novo alexander-novo force-pushed the alex/pow-elec-internal-external-residuals branch from 88b1700 to 52c72eb Compare April 30, 2026 20:46
@alexander-novo alexander-novo changed the base branch from alex/pow-elec-node-objects to develop April 30, 2026 20:46
@alexander-novo
Copy link
Copy Markdown
Collaborator Author

@pelesh Done

@pelesh pelesh merged commit e409ebf into develop Apr 30, 2026
6 checks passed
@alexander-novo alexander-novo deleted the alex/pow-elec-internal-external-residuals branch April 30, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants