Reorder DistributedGenerator variables#378
Merged
Conversation
alexander-novo
changed the base branch from
develop
to
alex/pow-elec-internal-external-residuals
alexander-novo
changed the base branch from
alex/pow-elec-internal-external-residuals
to
develop
alexander-novo
changed the base branch from
develop
to
alex/pow-elec-internal-external-residuals
pelesh
approved these changes
Apr 27, 2026
Collaborator
pelesh
left a comment
pelesh
left a comment
There was a problem hiding this comment.
Looks good. Go ahead and merge to the target branch.
alexander-novo
force-pushed
the
alex/pow-elec-internal-external-residuals
branch
from
c4b3e6f to
241cf82
Compare
alexander-novo
force-pushed
the
alex/power-elec-dg-reorder
branch
from
db31722 to
491b7ca
Compare
alexander-novo
force-pushed
the
alex/pow-elec-internal-external-residuals
branch
from
88b1700 to
52c72eb
Compare
alexander-novo
force-pushed
the
alex/power-elec-dg-reorder
branch
2 times, most recently
from
d87c9b3 to
77be7b9
Compare
alexander-novo
changed the base branch from
alex/pow-elec-internal-external-residuals
to
develop
Changed angle delta to be the last variable, since this variable isn't an internal for the reference generator.
alexander-novo
force-pushed
the
alex/power-elec-dg-reorder
branch
from
77be7b9 to
6e597c3
Compare
Collaborator
Author
|
@pelesh Rebased and pointing at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-ordered the internal variables of
DistributedGeneratorto place the angle delta at the end of the internal variables. This is a prerequisite for removing the copy to components vectors, since the indexing of internal variables currently differs between the references and non-reference generators.This PR changes it so all internal variables (besides the angle delta) have the same index between reference and non-reference generators.
Proposed changes
Checklist
-Wall -Wpedantic -Wconversion -Wextra.I will include this in the changelog update for removing the data copying (coming next)
Further comments