Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
closedparameter to theBranchmodel, allowing case files to faithfully import out-of-service transmission lines. Implemented as aRealTmask multiplier on residual contributions, following thed65bd4fIEEEST mask precedent (branch-free residuals for AD).Closes #370.
Proposed changes
BranchParameters::closed(bool, defaulttrue) new optional param in theBranchdevice'sparamsblock.RealT closed_{1.0}member onBranchmultiplied into all fourevaluateBusResidualNNoutputs. Whenclosed = false, residual contributions and Jacobian entries are zero, with no change to AD behavior. This approach, therefore, includes out-of-service branches in the sparsity structure. Long term, this should be optimized, but is out of scope here.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
A few of the larger cases have branches that I must omit when translating to
GridKitbecause we don't have a way to declare branch status. This is a part of a greater effort of mine to have as little friction in case translation as possible, so we can have full parity with PowerWorld cases.