Conversation
stonecoldhughes
left a comment
There was a problem hiding this comment.
Looks good. I would like to note that whispers of C++20 have reached even into the Contribution.md file. Perhaps something to revisit in the future.
|
I think it would also be a good idea to set a (soft) column limit of 120 characters. |
8eafdd4 to
7eed8e5
Compare
Add guidelines on line breaks.
|
Some details that I think should be added for clarification. Initializing classes with the Structures localized as parameter inputs. When there are a lot of parameters it becomes a lot more manageable to use structures to handle them. Perhaps add some details on this? These points come from details in the Also with regards to file names and classes. Perhaps state that files with only one class names must match the name of their file (or something similar). Otherwise looks good to me. |
|
I concur with @reid-g's points |
This is important issue but somewhat out of scope of this PR. @reid-g would you mind creating a separate GitHub issue with details and examples? |
* Add brief style guidelines. * Add header files include guidelines. * Add guidelines on line breaks, initializer list, file names.
This should probably be merged to
develop, but for opportunistic convenience, I suggest we merge it here. Since #1 will likely prompt discussion on new style guidelines, let's direct this PR tocomposer-devbranch.