Conversation
reid-g
reviewed
Apr 10, 2024
Collaborator
reid-g
left a comment
reid-g
left a comment
There was a problem hiding this comment.
This fixes the BusPV error so everything is good.
However, this removes pass individual parameter as input for construction. Thus limiting construction to only BusData. Other Buses still allow this construction do we want to remove that? This would be another pull request then.
Collaborator
Author
You are right. I restored the constructor with individual parameters. |
reid-g
approved these changes
Apr 10, 2024
Collaborator
reid-g
left a comment
reid-g
left a comment
There was a problem hiding this comment.
Looks good now and is consistent.
pelesh
added a commit
that referenced
this pull request
May 3, 2024
Prototype Example of Creating a RL Circuit +Add hypergraph representation +Added Model form with appropiate indexing +Added Resistors, Capacitor, Inductor, and VoltageSource Component Models +Added InductionMotor, Linear Transformer, and SynchronousMachine +Changes to PowerElectronicsModel * Added COO Sparse Matrices, Component Jacobians, and Discrete Generator + Basic COO Sparse Matrix Implmentation + Discrete Generator Component + Resistor Jacobian + Capacitor Jacobian + Voltage Source Jacobian + Inductor Jacobian + Testing for Sparse Jacobian and Discrete Generator * Added Jacobian Assembly. Fixed and Added New Functionality to COO Matrices +Matrix Assembly +Refactored COO Matrix +COO can return CSR Data format * Jacobian Assembly, IDA + KLU Cmake, RL Circuit + Cmake configurations for Sundials and SuiteSparse + Jacobian Assembly for components + Working RL Circuit example utilizing assembly techniques * Added the Transmission Line Component * Added Microgrid Example - Added MicrogridBusDQ - Added MicrogridLine - Added MicrogridLoad - Updated DiscreteGenerator - Added Output Testing for DG - Added Microgrid Assmebly Example - Updated Capacitor, Inductor, and Voltage residuals - Updated RLCircuit Example * Working Microgrid (Finite Difference) - "grounded" the rotor difference in reference - Comparing against reference from MATLAB * Fixed the Jacobian in Microgrid Example * Added a max step size control for model objects * Update Solver/Dynamic/CMakeLists.txt Co-authored-by: pelesh <peless@ornl.gov> * Updated name DiscreteGenerator -> DistributedGenerator - Updated name of generator - Some formatting updates * Fixed Some Bugs - Fixed SpMatTest - Updates on rebase * Fixed Memory Error with Grid3BusSys - Intalized Pg data * Fixed Unitalized Variable Stepsize * Remove parts of generator model from BusPV (#7) * Formatting updates + Fixed Warnings - Update format - Fixed casting warnings * Minor comments and style corrections. Co-authored-by: Reid <reid-g@users.noreply.github.com> * Multiple Format & Comment Updates + Valgrind Error Fixes - Updated Comments to respect current models - Fixed valgrind errors in ida.cpp. Note: there is still more but seg faults are happening from frees * Formatting Updates with "this" and using + Minor Fixes - Removed this-> with usings for formatting - Added using for Jac to components which did not have * Added Better Description to the MicrogridBus --------- Co-authored-by: Slaven Peles <peless@ornl.gov> Co-authored-by: Reid <reid-g@users.noreply.github.com>
pelesh
added a commit
that referenced
this pull request
Apr 14, 2025
* Remove parts of generator model from BusPV.
pelesh
added a commit
that referenced
this pull request
Apr 14, 2025
Prototype Example of Creating a RL Circuit +Add hypergraph representation +Added Model form with appropiate indexing +Added Resistors, Capacitor, Inductor, and VoltageSource Component Models +Added InductionMotor, Linear Transformer, and SynchronousMachine +Changes to PowerElectronicsModel * Added COO Sparse Matrices, Component Jacobians, and Discrete Generator + Basic COO Sparse Matrix Implmentation + Discrete Generator Component + Resistor Jacobian + Capacitor Jacobian + Voltage Source Jacobian + Inductor Jacobian + Testing for Sparse Jacobian and Discrete Generator * Added Jacobian Assembly. Fixed and Added New Functionality to COO Matrices +Matrix Assembly +Refactored COO Matrix +COO can return CSR Data format * Jacobian Assembly, IDA + KLU Cmake, RL Circuit + Cmake configurations for Sundials and SuiteSparse + Jacobian Assembly for components + Working RL Circuit example utilizing assembly techniques * Added the Transmission Line Component * Added Microgrid Example - Added MicrogridBusDQ - Added MicrogridLine - Added MicrogridLoad - Updated DiscreteGenerator - Added Output Testing for DG - Added Microgrid Assmebly Example - Updated Capacitor, Inductor, and Voltage residuals - Updated RLCircuit Example * Working Microgrid (Finite Difference) - "grounded" the rotor difference in reference - Comparing against reference from MATLAB * Fixed the Jacobian in Microgrid Example * Added a max step size control for model objects * Update Solver/Dynamic/CMakeLists.txt Co-authored-by: pelesh <peless@ornl.gov> * Updated name DiscreteGenerator -> DistributedGenerator - Updated name of generator - Some formatting updates * Fixed Some Bugs - Fixed SpMatTest - Updates on rebase * Fixed Memory Error with Grid3BusSys - Intalized Pg data * Fixed Unitalized Variable Stepsize * Remove parts of generator model from BusPV (#7) * Formatting updates + Fixed Warnings - Update format - Fixed casting warnings * Minor comments and style corrections. Co-authored-by: Reid <reid-g@users.noreply.github.com> * Multiple Format & Comment Updates + Valgrind Error Fixes - Updated Comments to respect current models - Fixed valgrind errors in ida.cpp. Note: there is still more but seg faults are happening from frees * Formatting Updates with "this" and using + Minor Fixes - Removed this-> with usings for formatting - Added using for Jac to components which did not have * Added Better Description to the MicrogridBus --------- Co-authored-by: Slaven Peles <peless@ornl.gov> Co-authored-by: Reid <reid-g@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2.